Re: [nongnu] elpa/scala-mode c2a4f58643 1/2: Revert "scala-mode-indent.el: remove unused arg from `goto-block-anchor`"

Re: [nongnu] elpa/scala-mode c2a4f58643 1/2: Revert "scala-mode-indent.el: remove unused arg from `goto-block-anchor`"

[Stefan Monnier]

> branch: elpa/scala-mode
> commit c2a4f58643eb505f38c8e341a29400e79f47f442
> Author: Konstantin Kharlamov <Hi-Angel@yandex.ru>
> Commit: Konstantin Kharlamov <Hi-Angel@yandex.ru>
>
>     Revert "scala-mode-indent.el: remove unused arg from `goto-block-anchor`"
[...]
> @@ -583,7 +583,7 @@ keyword, or nil if not."
>  ;;; Block
>  ;;;
>  
> -(defun scala-indent:goto-block-anchor ()
> +(defun scala-indent:goto-block-anchor (&optional point)
>    "Moves back to the point whose column will be used as the
>  anchor for calculating block indent for current point (or point
>  `point'). Returns point or (point-min) if not inside a block."

If the argument is unused, then you should rename it to `_point` which
(by convention) says explicitly that this arg is not used.


        Stefan

Re: [nongnu] elpa/scala-mode c2a4f58643 1/2: Revert "scala-mode-indent.el: remove unused arg from `goto-block-anchor`"

[Konstantin Kharlamov]

On Mon, 2024-12-30 at 19:08 -0500, Stefan Monnier wrote:
> > branch: elpa/scala-mode
> > commit c2a4f58643eb505f38c8e341a29400e79f47f442
> > Author: Konstantin Kharlamov <Hi-Angel@yandex.ru>
> > Commit: Konstantin Kharlamov <Hi-Angel@yandex.ru>
> > 
> >     Revert "scala-mode-indent.el: remove unused arg from `goto-
> > block-anchor`"
> [...]
> > @@ -583,7 +583,7 @@ keyword, or nil if not."
> >  ;;; Block
> >  ;;;
> >  
> > -(defun scala-indent:goto-block-anchor ()
> > +(defun scala-indent:goto-block-anchor (&optional point)
> >    "Moves back to the point whose column will be used as the
> >  anchor for calculating block indent for current point (or point
> >  `point'). Returns point or (point-min) if not inside a block."
> 
> If the argument is unused, then you should rename it to `_point`
> which
> (by convention) says explicitly that this arg is not used.

Oh, thank you! The reason I didn't do this is because when I tried
prefixing an optional param with underscore in some other instance, I
was getting parsing error. However, I can't reproduce it anymore, and
now that I'm trying to, I suspect it wasn't because of the underscore,
but rather because the make file in scala-mode sometimes prints `End of
file during parsing`, which I attributed to Emacs byte-compiler. The
Makefile is very poorly written (it also lacks some `.el` files and it
has broken rebuilds because it saves `.latest-build` file for some
reason and disregards the el vs elc files timestamps), so… yeah, I just
got confused.

Re: [nongnu] elpa/scala-mode c2a4f58643 1/2: Revert "scala-mode-indent.el: remove unused arg from `goto-block-anchor`"

[Stefan Monnier]

> Oh, thank you! The reason I didn't do this is because when I tried
> prefixing an optional param with underscore in some other instance, I
> was getting parsing error. However, I can't reproduce it anymore, and
> now that I'm trying to, I suspect it wasn't because of the underscore,
> but rather because the make file in scala-mode sometimes prints `End of
> file during parsing`, which I attributed to Emacs byte-compiler. The
> Makefile is very poorly written (it also lacks some `.el` files and it
> has broken rebuilds because it saves `.latest-build` file for some
> reason and disregards the el vs elc files timestamps), so… yeah, I just
> got confused.

Programming is all about dealing with confusion!  🙂


        Stefan