unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: rms@gnu.org, spiegel@gnu.org, emacs-devel@gnu.org
Subject: Re: Fwd: vc-svn.el and "the underscore hack"
Date: Wed, 01 Nov 2006 11:29:23 -0500	[thread overview]
Message-ID: <jwvfyd3m8tq.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <17735.25691.286000.488074@gargle.gargle.HOWL> (AriT's message of "Tue\, 31 Oct 2006 08\:57\:31 -0600")

>> Would someone like to work on this?  There is a proposed patch
>> in the second message.

> I have tested this now on both windows and Gentoo GNU/Linux and have
> not encountered any issues.  However I have recently been using
> psvn.el from http://www.xsteve.at/prg/emacs/psvn.el and in that file
> they are using a defun to set the svn admin directory name. The
> function checks for environment to determine which directory name to
> use (.svn or _svn).  That looks like a better way to do it than what I
> did in my patch.  I will attempt to make a similar change to vc-svn.el
> and submit a patch if there are no objections.  

> I do have one question, is this list the correct place to post that
> patch or should it be sent to the subversion people.  vc-svn.el
> indicates that this file is maintained here.  I just wanted to make
> sure I send it to the right place.

As mentioned elsewhere the ".foo -> _foo" transformation is not specific to
Subversion and/or Emacs, so I think we should not handle it specially in
vc-svn.el but instead in a more generic way, maybe directly in the C code or
at least by providing a function that handles it.


        Stefan

  parent reply	other threads:[~2006-11-01 16:29 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-17  6:54 [arit93@yahoo.com: vc-svn.el and "the underscore hack"] Richard Stallman
2006-10-31 14:57 ` AriT93
2006-11-01  2:14   ` Richard Stallman
2006-11-01 16:29   ` Stefan Monnier [this message]
2006-11-01 21:02     ` Fwd: vc-svn.el and "the underscore hack" AriT93
2006-11-02  4:43     ` Richard Stallman
2006-11-05 19:23     ` Richard Stallman
2006-11-07 17:23       ` AriT93
2006-11-08 16:58         ` Richard Stallman
2006-11-08 21:23         ` Kevin Rodgers
2006-11-08 21:32           ` AriT93
2006-11-09  1:00           ` David Kastrup
2006-11-09  1:56         ` Chong Yidong
2006-11-09  2:01           ` David Kastrup
2006-11-09  2:06             ` Juanma Barranquero
2006-11-09  2:55               ` David Kastrup
2006-11-09  3:18           ` AriT93
2006-11-09 23:27           ` Richard Stallman
2006-11-09  3:18         ` Chong Yidong
2006-11-09  3:23           ` AriT93
2006-11-09 16:23           ` AriT93
     [not found] ` <17735.25421.968000.773096@gargle.gargle.HOWL>
2006-11-01  2:14   ` [arit93@yahoo.com: vc-svn.el and "the underscore hack"] Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvfyd3m8tq.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    --cc=spiegel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).