From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: bookmark.el and lisp/gnus/gnus-bookmark.el Date: Sat, 08 Mar 2008 18:20:30 -0500 Message-ID: References: <874pbj682f.fsf@red-bean.com> <87zltbhbq8.fsf@bzg.ath.cx> <87iqzzigv6.fsf@bzg.ath.cx> <87ejan7xhq.fsf@member.fsf.org> <87hcfi3egg.fsf@bzg.ath.cx> <87abla8w6b.fsf@member.fsf.org> <87bq5qhba6.fsf@bzg.ath.cx> <871w6m8t59.fsf@member.fsf.org> <87ablamphg.fsf@red-bean.com> <87skz2lacp.fsf@bzg.ath.cx> <87tzjil9oz.fsf@red-bean.com> <8763vyl964.fsf@bzg.ath.cx> <874pbiypad.fsf@bzg.ath.cx> <87ejalv8an.fsf@bzg.ath.cx> <87pru5gcy9.fsf@bzg.ath.cx> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1205018450 17630 80.91.229.12 (8 Mar 2008 23:20:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 8 Mar 2008 23:20:50 +0000 (UTC) Cc: Karl Fogel , Tassilo Horn , Reiner Steib , emacs-devel@gnu.org To: Bastien Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 09 00:21:16 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JY8Lp-0004Rf-Ii for ged-emacs-devel@m.gmane.org; Sun, 09 Mar 2008 00:21:13 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JY8LH-0005Mz-FT for ged-emacs-devel@m.gmane.org; Sat, 08 Mar 2008 18:20:39 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JY8LC-0005MQ-Sr for emacs-devel@gnu.org; Sat, 08 Mar 2008 18:20:34 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JY8LA-0005LU-7u for emacs-devel@gnu.org; Sat, 08 Mar 2008 18:20:34 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JY8LA-0005LK-41 for emacs-devel@gnu.org; Sat, 08 Mar 2008 18:20:32 -0500 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JY8L9-0001ao-QK for emacs-devel@gnu.org; Sat, 08 Mar 2008 18:20:31 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArcCAO6t0kfO+J2CdGdsb2JhbACQfQEwmRuBBw X-IronPort-AV: E=Sophos;i="4.25,468,1199682000"; d="scan'208";a="15749590" Original-Received: from smtp.pppoe.ca ([65.39.196.238]) by ironport2-out.pppoe.ca with ESMTP; 08 Mar 2008 18:20:30 -0500 Original-Received: from pastel.home ([206.248.157.130]) by smtp.pppoe.ca (Internet Mail Server v1.0) with ESMTP id OAC51130; Sat, 08 Mar 2008 18:20:30 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 1E6777FD4; Sat, 8 Mar 2008 18:20:30 -0500 (EST) In-Reply-To: <87pru5gcy9.fsf@bzg.ath.cx> (Bastien's message of "Sat, 08 Mar 2008 20:47:42 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:91798 Archived-At: >>> If we get rid of the annotation argument for this single function, it >>> means the annotation has to be done before this function returns sth >>> that can be used as the suggested name for the bookmark. >> >> AFAICT getting rid of the annotation argument means nothing at all, >> other than that the annotation will have to be added by the generic >> bookmark-set code rather than being done by every single >> bookmark-make-record-function. > For now `bookmark-set' asks for an annotation (if required), sends it to > `bookmark-make' which calls `bookmark-make-record-function' with the > annotation as an argument. > IIUC Tassilo suggested that the annotation should be directly handled by > `bookmark-make-record-function', which seems correct to me. What you > propose is to handle annotation in `bookmark-set' (or preferrably in > `bookmark-make') -- this is _feasible_, but it looks weird to me since > the annotation is really part of the record. The record has various parts: a name to select it, an annotation, a bunch of data to find the place, there could be more (date the record was created, when it was last used, ...). The bookmark-make-record-function should only concern itself with providing the data to find the place. It may also provide a default name, a default annotation, ... but it's better if it doesn't need to handle annotations since those are (or rather should be) handled identically for *all* bookmark-make-record-function. Stefan