From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] lisp/files.el and lisp/buf-menu.el Date: Fri, 17 Jul 2009 11:46:41 -0400 Message-ID: References: <1247777220.6302.56.camel@dell-desktop.example.com> <1247806613.6302.169.camel@dell-desktop.example.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1247845624 485 80.91.229.12 (17 Jul 2009 15:47:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Jul 2009 15:47:04 +0000 (UTC) Cc: emacs-devel To: Thomas Lord Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 17 17:46:57 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MRpe9-0006iL-Q3 for ged-emacs-devel@m.gmane.org; Fri, 17 Jul 2009 17:46:54 +0200 Original-Received: from localhost ([127.0.0.1]:57001 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MRpe9-0002hD-4o for ged-emacs-devel@m.gmane.org; Fri, 17 Jul 2009 11:46:53 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MRpe5-0002gy-BH for emacs-devel@gnu.org; Fri, 17 Jul 2009 11:46:49 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MRpe0-0002gm-QU for emacs-devel@gnu.org; Fri, 17 Jul 2009 11:46:48 -0400 Original-Received: from [199.232.76.173] (port=59450 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MRpe0-0002gj-LR for emacs-devel@gnu.org; Fri, 17 Jul 2009 11:46:44 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:57787) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MRpe0-0003GZ-7u for emacs-devel@gnu.org; Fri, 17 Jul 2009 11:46:44 -0400 Original-Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id n6HFkfo4005287; Fri, 17 Jul 2009 11:46:41 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 0D3163A39C; Fri, 17 Jul 2009 11:46:41 -0400 (EDT) In-Reply-To: <1247806613.6302.169.camel@dell-desktop.example.com> (Thomas Lord's message of "Thu, 16 Jul 2009 21:56:53 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.94 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3320=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:112618 Archived-At: > I did initially solve this problem with > (let ((buffer-file-name yaddayadda)) (normal-mode)) > I wasn't happy with that because I assume > that the binding of buffer-file-name should > be one of: nil, a local file, a remote file. > I don't know what code distributed with > Emacs or what third party Emacs code would > break under other conditions. That is > why my patch adds buffer-automode-file-name. As shown in the code I sent a few days ago, PCL-CVS does use such a let-binding (and uses after-find-file rather than normal-mode), so I wouldn't worry too much about it. > LIST-BUFFERS-DESCRIPTION differs from ...-DIRECTORY > by being better named (so people won't > assume it necessarily refers to a "directory") > and with a doc string. I don't know > to what extent third party code assumes that > LIST-BUFFERS-DIRECTORY is, well, a directory > and so I didn't want to overload it. So the better thing to do would be to suggest renaming list-buffers-directory to list-buffers-description and adding a docstring. > I'm not clear on what you suggest I do about > coding systems. I'm just pointing out you may want to reuse more of the code used to open files, so it also obeys things like the -*- coding -*- tags as well as file-coding-system-alist. Stefan