From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: bug#881: patch for bug #881 Date: Wed, 06 Jan 2010 15:19:16 -0500 Message-ID: References: <87wrzwp5gd.fsf@stupidchicken.com> <201001060700.o06706Sw006855@godzilla.ics.uci.edu> <201001061829.o06IT0Zm002189@godzilla.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1262809178 26734 80.91.229.12 (6 Jan 2010 20:19:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 Jan 2010 20:19:38 +0000 (UTC) Cc: Juanma Barranquero , Chong Yidong , Emacs developers To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 06 21:19:31 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NScLq-0002mW-Q5 for ged-emacs-devel@m.gmane.org; Wed, 06 Jan 2010 21:19:31 +0100 Original-Received: from localhost ([127.0.0.1]:36441 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NScLr-0006Hu-7J for ged-emacs-devel@m.gmane.org; Wed, 06 Jan 2010 15:19:31 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NScLk-0006Ei-Mn for emacs-devel@gnu.org; Wed, 06 Jan 2010 15:19:24 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NScLh-000650-09 for emacs-devel@gnu.org; Wed, 06 Jan 2010 15:19:24 -0500 Original-Received: from [199.232.76.173] (port=56266 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NScLg-00064Y-K4 for emacs-devel@gnu.org; Wed, 06 Jan 2010 15:19:20 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:45856) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NScLg-0007Gc-BU for emacs-devel@gnu.org; Wed, 06 Jan 2010 15:19:20 -0500 Original-Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id o06KJGtQ030537; Wed, 6 Jan 2010 15:19:16 -0500 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 2404E3A317; Wed, 6 Jan 2010 15:19:16 -0500 (EST) In-Reply-To: <201001061829.o06IT0Zm002189@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Wed, 6 Jan 2010 10:29:00 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3442=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:119539 Archived-At: >> > How should it work? We don't have any nice generic mechanism/UI for >> > doing VC backend specific things in the commit buffer. >> It's a general concept, although it's not supported by all backends. > The general concept is that backends want to do backend specific things :-) That's another part. But for "author", I think we should support it in the generic part of the VC code. After all, it's a concept we've been using in ChangeLog for ages: the fact that only recent VCS support it is no excuse ;-) > This would be helpful, but not enough, we also want to have some key > bindings, menu entries for backend specific things. > So how about starting by replacing the call to `log-edit' in > `vc-log-edit' with (vc-call-backend backend 'log-edit) > and then each backend that so desires can implement a mode derived from > log-edit and do whatever it wants (like we do for log-view). Fine by me. But please remember that whenever possible and meaningful, it's better to add features to vc.el than to particular backends. Stefan