From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Emacs 23.1.93 pretest Date: Sat, 27 Feb 2010 14:41:42 -0500 Message-ID: References: <87pr3rny7e.fsf@stupidchicken.com> <83fx4n122q.fsf@gnu.org> <833a0ndlo0.fsf@gnu.org> <83pr3qddl4.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1267299833 7149 80.91.229.12 (27 Feb 2010 19:43:53 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 27 Feb 2010 19:43:53 +0000 (UTC) Cc: Juanma Barranquero , cyd@stupidchicken.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 27 20:43:48 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NlSZo-0002uL-2l for ged-emacs-devel@m.gmane.org; Sat, 27 Feb 2010 20:43:48 +0100 Original-Received: from localhost ([127.0.0.1]:39655 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NlSZn-0002D8-Gy for ged-emacs-devel@m.gmane.org; Sat, 27 Feb 2010 14:43:47 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NlSXv-0001Ob-BU for emacs-devel@gnu.org; Sat, 27 Feb 2010 14:41:51 -0500 Original-Received: from [140.186.70.92] (port=40528 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NlSXu-0001O1-G0 for emacs-devel@gnu.org; Sat, 27 Feb 2010 14:41:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NlSXt-0007rH-Ne for emacs-devel@gnu.org; Sat, 27 Feb 2010 14:41:50 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183]:25079 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NlSXp-0007qi-V7; Sat, 27 Feb 2010 14:41:46 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAGEEiUtMCrTT/2dsb2JhbACbG3S5MoR7BIMXh3E X-IronPort-AV: E=Sophos;i="4.49,551,1262581200"; d="scan'208";a="56943372" Original-Received: from 76-10-180-211.dsl.teksavvy.com (HELO pastel.home) ([76.10.180.211]) by ironport2-out.pppoe.ca with ESMTP; 27 Feb 2010 14:41:43 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 5D6A180E3; Sat, 27 Feb 2010 14:41:42 -0500 (EST) In-Reply-To: <83pr3qddl4.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 27 Feb 2010 15:15:35 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.92 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:121452 Archived-At: > But then how come this defense in uniscribe_check_otf did not catch > it? > /* Check the spec is in the right format. */ > if (!CONSP (otf_spec) || Flength (otf_spec) < 3) > return 0; Once again I recommend that people compile with -DUSE_LISP_UNION_TYPE to catch such bugs. They're trivial to catch this way. Stefan