From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: minibuffer-completion-contents obsolete Date: Sun, 21 Apr 2013 00:03:56 -0400 Message-ID: References: <87vc7hbq12.fsf@gmail.com> <87sj2l2pnz.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1366517042 25844 80.91.229.3 (21 Apr 2013 04:04:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 21 Apr 2013 04:04:02 +0000 (UTC) Cc: emacs-devel@gnu.org To: Thierry Volpiatto Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 21 06:04:06 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UTlVT-0005zQ-RC for ged-emacs-devel@m.gmane.org; Sun, 21 Apr 2013 06:04:03 +0200 Original-Received: from localhost ([::1]:54142 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTlVT-0002WM-BP for ged-emacs-devel@m.gmane.org; Sun, 21 Apr 2013 00:04:03 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41319) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTlVQ-0002WG-0l for emacs-devel@gnu.org; Sun, 21 Apr 2013 00:04:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UTlVP-0003I7-1O for emacs-devel@gnu.org; Sun, 21 Apr 2013 00:03:59 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:20296) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTlVO-0003I1-SZ for emacs-devel@gnu.org; Sun, 21 Apr 2013 00:03:58 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFHO+LAd/2dsb2JhbABEuzWDWRdzgh4BAQQBViMQCzQSFBgNJIgeBsEtkQoDpHqBXoMT X-IPAS-Result: Av8EABK/CFHO+LAd/2dsb2JhbABEuzWDWRdzgh4BAQQBViMQCzQSFBgNJIgeBsEtkQoDpHqBXoMT X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="7896316" Original-Received: from 206-248-176-29.dsl.teksavvy.com (HELO ceviche.home) ([206.248.176.29]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 21 Apr 2013 00:03:53 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 3683A660E8; Sun, 21 Apr 2013 00:03:56 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Sat, 20 Apr 2013 23:28:53 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159070 Archived-At: >> I use it in helm and eldoc-eval. > That says where you use it, but not what you use it for. E.g. why not use the patch below? Stefan === modified file 'packages/eldoc-eval/eldoc-eval.el' --- packages/eldoc-eval/eldoc-eval.el 2013-01-13 20:20:14 +0000 +++ packages/eldoc-eval/eldoc-eval.el 2013-04-21 04:02:47 +0000 @@ -149,21 +149,15 @@ (defun eldoc-mode-in-minibuffer () "Show eldoc for current minibuffer input." - (let ((buf (with-selected-window (minibuffer-window) - (buffer-name)))) + (let ((buf (window-buffer (minibuffer-window)))) ;; If this minibuffer have been started with ;;`with-eldoc-in-minibuffer' give it eldoc support ;; and update mode-line, otherwise do nothing. (when (member buf eldoc-active-minibuffers-list) - (let* ((str-all (with-current-buffer buf - (minibuffer-completion-contents))) - (sym (when str-all - (with-temp-buffer - (insert str-all) - (goto-char (point-max)) + (let* ((sym (with-current-buffer buf (unless (looking-back ")\\|\"") (forward-char -1)) - (eldoc-current-symbol)))) + (eldoc-current-symbol))) (info-fn (eldoc-fnsym-in-current-sexp)) (doc (or (eldoc-get-var-docstring sym) (eldoc-get-fnsym-args-string