From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: /srv/bzr/emacs/elpa r395: * company.el (company-capf): Add support for `sorted' and `post-completion'. Date: Sun, 05 May 2013 23:22:50 -0400 Message-ID: References: <87vc6yz9r4.fsf@yandex.ru> <51861D6D.8030709@yandex.ru> <518718E4.3090108@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1367810579 17682 80.91.229.3 (6 May 2013 03:22:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 6 May 2013 03:22:59 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 06 05:22:58 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UZC0v-0005xk-SN for ged-emacs-devel@m.gmane.org; Mon, 06 May 2013 05:22:57 +0200 Original-Received: from localhost ([::1]:53102 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZC0v-0006uS-DO for ged-emacs-devel@m.gmane.org; Sun, 05 May 2013 23:22:57 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZC0r-0006uN-77 for emacs-devel@gnu.org; Sun, 05 May 2013 23:22:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZC0q-00066U-2Y for emacs-devel@gnu.org; Sun, 05 May 2013 23:22:53 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:19614) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZC0p-00066K-U4 for emacs-devel@gnu.org; Sun, 05 May 2013 23:22:51 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFMCqRF/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYHCxQYDSSIHgbBLZEKA6R6gV6DEw X-IPAS-Result: Av4EABK/CFFMCqRF/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYHCxQYDSSIHgbBLZEKA6R6gV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="11134823" Original-Received: from 76-10-164-69.dsl.teksavvy.com (HELO pastel.home) ([76.10.164.69]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 05 May 2013 23:22:46 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 7666F67A30; Sun, 5 May 2013 23:22:50 -0400 (EDT) In-Reply-To: <518718E4.3090108@yandex.ru> (Dmitry Gutov's message of "Mon, 06 May 2013 06:43:48 +0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159358 Archived-At: >>>>> Like the header in company.el says, we still try to support Emacs 22 and >>>>> 23. `pcase' was only added in 23.3, I believe. >>>> But this is in a comment, so it's not a problem. >>> I'm not sure recommending to users to write new backends in a way >>> incompatible with older Emacs is good. >> It is in my interest to encourage all users to move to a more >> recent Emacs. > I still don't like the dissonance between the "Compatibility" header and > this recommendation, not far below it. But if you insist, let's keep it > that way. I definitely do not insist on it. I just explain why I committed the code this way. But as maintainer of company, you're free to make a different decision. >> And even more so to encourage them to move away from `cl' >> (which will be a long and arduous path, so every bit helps). > While we're on the subject of `cl', why not use `cl-lib' and `cl-case'? No strong reason: 1- cl-lib is even more bleeding-edge. 2- I wrote pcase, so I like pcase. > I guess that is true. And if you're just arguing against having a similar > field in `completion-extra-properties', I'm fine with that. That's indeed the point. > package.el doesn't have an easy way to install a non-latest version > of a package, so it will affect any users with old Emacs who are updating or > reinstalling the package. Provided they sometimes use `company-begin-with', > of course. GNU ELPA is mostly meant for Emacs>=24. We don't actively try to prevent users of Emacs<24 from using GNU ELPA, but several of GNU ELPA packages only work in Emacs>=24. We can/should add a package-require for (emacs "24.1") or whichever version is needed, so that package.el won't automatically upgrade to a package that doesn't work in the currently running Emacs. Stefan