unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: /srv/bzr/emacs/elpa r395: * company.el (company-capf): Add support for `sorted' and `post-completion'.
Date: Sun, 05 May 2013 23:22:50 -0400	[thread overview]
Message-ID: <jwvfvy0iyyn.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <518718E4.3090108@yandex.ru> (Dmitry Gutov's message of "Mon, 06 May 2013 06:43:48 +0400")

>>>>> Like the header in company.el says, we still try to support Emacs 22 and
>>>>> 23. `pcase' was only added in 23.3, I believe.
>>>> But this is in a comment, so it's not a problem.
>>> I'm not sure recommending to users to write new backends in a way
>>> incompatible with older Emacs is good.
>> It is in my interest to encourage all users to move to a more
>> recent Emacs.
> I still don't like the dissonance between the "Compatibility" header and
> this recommendation, not far below it. But if you insist, let's keep it
> that way.

I definitely do not insist on it.  I just explain why I committed the
code this way.  But as maintainer of company, you're free to make
a different decision.

>> And even more so to encourage them to move away from `cl'
>> (which will be a long and arduous path, so every bit helps).
> While we're on the subject of `cl', why not use `cl-lib' and `cl-case'?

No strong reason:
1- cl-lib is even more bleeding-edge.
2- I wrote pcase, so I like pcase.

> I guess that is true.  And if you're just arguing against having a similar
> field in `completion-extra-properties', I'm fine with that.

That's indeed the point.

> package.el doesn't have an easy way to install a non-latest version
> of a package, so it will affect any users with old Emacs who are updating or
> reinstalling the package. Provided they sometimes use `company-begin-with',
> of course.

GNU ELPA is mostly meant for Emacs>=24.  We don't actively try to
prevent users of Emacs<24 from using GNU ELPA, but several of GNU ELPA
packages only work in Emacs>=24.

We can/should add a package-require for (emacs "24.1") or whichever
version is needed, so that package.el won't automatically upgrade to
a package that doesn't work in the currently running Emacs.


        Stefan



  reply	other threads:[~2013-05-06  3:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1UW5x9-0001hw-8W@vcs.savannah.gnu.org>
2013-05-04 21:59 ` /srv/bzr/emacs/elpa r395: * company.el (company-capf): Add support for `sorted' and `post-completion' Dmitry Gutov
2013-05-05  6:32   ` Stefan Monnier
2013-05-05  8:50     ` Dmitry Gutov
2013-05-05 10:05       ` Sebastian Wiesner
2013-05-05 10:13         ` Dmitry Gutov
2013-05-06  1:18       ` Stefan Monnier
2013-05-06  2:43         ` Dmitry Gutov
2013-05-06  3:22           ` Stefan Monnier [this message]
2013-05-09 20:35             ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvfvy0iyyn.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).