From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: eww Date: Tue, 18 Jun 2013 15:07:07 -0400 Message-ID: References: <87d2rkb1pi.fsf@fleche.redhat.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1371582440 7861 80.91.229.3 (18 Jun 2013 19:07:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 18 Jun 2013 19:07:20 +0000 (UTC) Cc: Tom Tromey , ding@gnus.org, emacs-devel To: Lars Magne Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 18 21:07:19 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Up1FM-0002gf-Ph for ged-emacs-devel@m.gmane.org; Tue, 18 Jun 2013 21:07:16 +0200 Original-Received: from localhost ([::1]:41549 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Up1FM-00016l-7x for ged-emacs-devel@m.gmane.org; Tue, 18 Jun 2013 15:07:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Up1FH-00010B-6W for emacs-devel@gnu.org; Tue, 18 Jun 2013 15:07:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Up1FG-0001MV-1t for emacs-devel@gnu.org; Tue, 18 Jun 2013 15:07:11 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:59683) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Up1FF-0001MP-Us for emacs-devel@gnu.org; Tue, 18 Jun 2013 15:07:09 -0400 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.DIT.UMontreal.CA (8.14.1/8.14.1) with ESMTP id r5IJ775V018195; Tue, 18 Jun 2013 15:07:07 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 7AB61B4178; Tue, 18 Jun 2013 15:07:07 -0400 (EDT) In-Reply-To: (Lars Magne Ingebrigtsen's message of "Tue, 18 Jun 2013 13:23:02 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV4613=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4613> : streams <984418> : uri <1451673> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:160596 gmane.emacs.gnus.general:83372 Archived-At: >> +(defvar eww-next-url nil) >> +(make-variable-buffer-local 'eww-next-url) >> +(defvar eww-previous-url nil) >> +(make-variable-buffer-local 'eww-previous-url) >> +(defvar eww-up-url nil) >> +(make-variable-buffer-local 'eww-up-url) >> +(defvar eww-top-url nil) >> +(make-variable-buffer-local 'eww-top-url) > I think that for package-specific variables like this we're supposed to > use > (set (make-local-variable 'eww-top-url) nil) > in the mode setup instead, so that we're not making variables needlessly > globally buffer-local. For variables whose global value is of no use anyway, you're just as well to use defvar-local (or equivalent) like Tom did. Stefan