From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Simple lisp-tests.el and commit privs Date: Tue, 20 Aug 2013 16:54:49 -0400 Message-ID: References: <87y584c6gv.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1377032109 11203 80.91.229.3 (20 Aug 2013 20:55:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 20 Aug 2013 20:55:09 +0000 (UTC) Cc: Dmitry Gutov , emacs-devel@gnu.org To: Barry OReilly Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 20 22:55:10 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VBsxI-0000hM-RP for ged-emacs-devel@m.gmane.org; Tue, 20 Aug 2013 22:55:08 +0200 Original-Received: from localhost ([::1]:49756 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBsxI-0002zw-G9 for ged-emacs-devel@m.gmane.org; Tue, 20 Aug 2013 16:55:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBsx8-0002xG-1K for emacs-devel@gnu.org; Tue, 20 Aug 2013 16:55:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VBsx0-0003UF-Jw for emacs-devel@gnu.org; Tue, 20 Aug 2013 16:54:57 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:42754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBsx0-0003U8-F4 for emacs-devel@gnu.org; Tue, 20 Aug 2013 16:54:50 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFHO+LNT/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgaxH5AOkQoDpHqBXoMT X-IPAS-Result: Av8EABK/CFHO+LNT/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgaxH5AOkQoDpHqBXoMT X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="22665341" Original-Received: from 206-248-179-83.dsl.teksavvy.com (HELO pastel.home) ([206.248.179.83]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 20 Aug 2013 16:54:42 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 3233663170; Tue, 20 Aug 2013 16:54:49 -0400 (EDT) In-Reply-To: (Barry OReilly's message of "Tue, 20 Aug 2013 12:04:15 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162933 Archived-At: > Expected success (current behavior): > --- ruby.rb 2013-08-20 11:29:39.000000000 -0400 > +++ ruby.rb.new 2013-08-20 11:29:42.000000000 -0400 > @@ -35,8 +35,8 @@ > if a == 2 > puts "hello" > - else > - puts "there" > + else > + puts "there" > end > if a == 2 then > Unexpected failure (if "else" didn't move -- is not current behavior): > if a == 2 > puts "hello" > else > - puts "there" > + puts "there" > end > if a == 2 then I don't see what's the problem here: if indent/ruby.rb contains: if a == 2 puts "hello" else puts "there" puts "there" end then presumably the bug would get caught. You may have to run the test by first flushing all the code to the left margin before reindenting, but if reindentation works correctly both when started "at left-margin" and when started "at the correct indentation", then there's a very high probability that it will work in most/all other cases as well. Do you know of bugs that have occurred and that wouldn't be caught this way? >> Why not have a ert-with-temp-buffer which if the test fails (within >> the form), a file would be saved off with the buffer contents. >> Ideally the test case name would be in the generated filename. > Is this inadequate to address your debugging needs? I still don't see what problem this is trying to address. Stefan