From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: History for query replace pairs Date: Sun, 09 Nov 2014 17:14:08 -0500 Message-ID: References: <87iojduj9n.fsf@mail.jurta.org> <87k33nyirh.fsf@mail.jurta.org> <87sii0becx.fsf@lifelogs.com> <87ioivx2xk.fsf@mail.jurta.org> <87h9yfaihq.fsf@lifelogs.com> <87zjc6pnpg.fsf@mail.jurta.org> <87r3xhnsjb.fsf@mail.jurta.org> <87zjc2pou7.fsf@mail.jurta.org> <87zjc2fqx2.fsf@lifelogs.com> <83oasiqduw.fsf@gnu.org> <87ioiq7yre.fsf@mail.jurta.org> <83ioiqq6j8.fsf@gnu.org> <87vbmpnw3a.fsf@mail.jurta.org> <83d28wpcy1.fsf@gnu.org> <87mw805mem.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1415571294 15488 80.91.229.3 (9 Nov 2014 22:14:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 9 Nov 2014 22:14:54 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 09 23:14:47 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Xnakv-0007V1-By for ged-emacs-devel@m.gmane.org; Sun, 09 Nov 2014 23:14:45 +0100 Original-Received: from localhost ([::1]:40160 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xnaku-0004ck-KE for ged-emacs-devel@m.gmane.org; Sun, 09 Nov 2014 17:14:44 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xnaka-0004cD-Lj for emacs-devel@gnu.org; Sun, 09 Nov 2014 17:14:32 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XnakT-0005pM-6E for emacs-devel@gnu.org; Sun, 09 Nov 2014 17:14:24 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:13819) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XnakL-0005oK-7I; Sun, 09 Nov 2014 17:14:09 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Au0MAOatTlRLd+sd/2dsb2JhbABcgw6DYoZ+y1MEAgKBHBcBAXyEAwEBBCcvIxALNBIUGA0kiFTLcgEBAQEGAQEBAR6RCAeESwWLZKY8gW+EFh+CegEBAQ X-IPAS-Result: Au0MAOatTlRLd+sd/2dsb2JhbABcgw6DYoZ+y1MEAgKBHBcBAXyEAwEBBCcvIxALNBIUGA0kiFTLcgEBAQEGAQEBAR6RCAeESwWLZKY8gW+EFh+CegEBAQ X-IronPort-AV: E=Sophos;i="5.04,797,1406606400"; d="scan'208";a="96498375" Original-Received: from 75-119-235-29.dsl.teksavvy.com (HELO ceviche.home) ([75.119.235.29]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 09 Nov 2014 17:14:08 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 0A2B866100; Sun, 9 Nov 2014 17:14:08 -0500 (EST) In-Reply-To: <87mw805mem.fsf@mail.jurta.org> (Juri Linkov's message of "Sun, 09 Nov 2014 19:11:45 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:176652 Archived-At: > + (propertize > + "\0" > + 'display (propertize > + (if (and > + ;; Don't call char-displayable-p while pre-loading replace. > + (not (equal (car preloaded-file-list) "replace")) > + (char-displayable-p ?\u2192)) " \u2192 " " -> ") > + 'face 'minibuffer-prompt) > + 'separator t) I think the (propertize "\0" ... 'separator t) wrapper should *not* be customizable. And making the arrow cutomizable seems like a bad idea anyway, just pushing the problem onto the user. The (not (equal (car preloaded-file-list) "replace")) test makes no sense. Why don't we want to call char-displayable-p while pre-loading replace? Shouldn't we instead test (fboundp 'char-displayable-p) or simply wrap the code in ignore-errors (if the problem is that char-displayable-p fails when run without a real frame at hand, which might also happen in daemon mode)? Stefan