unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: etags completion table
Date: Sat, 30 May 2015 00:00:35 -0400	[thread overview]
Message-ID: <jwvfv6era24.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <5568FD22.4010004@yandex.ru> (Dmitry Gutov's message of "Sat, 30 May 2015 02:58:26 +0300")

>> I see the first patch says that it takes 1.34s to build the obarray and
>> 0.78s to build an equivalent list of strings, so we could change the
>> code so as to keep the completion table as a pre-built list of strings
>> instead of a pre-built obarray.  It will also save us a bit of memory.
> Maybe. The difference isn't much, though, and it's a one-time thing.

Agreed.  But the current use of an obarray is just wrong: it makes the
code use more CPU and memory resources for no benefit.


        Stefan



  reply	other threads:[~2015-05-30  4:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <555EC552.5010600@swipnet.se>
     [not found] ` <837frvywfn.fsf@gnu.org>
     [not found]   ` <55650812.60909@yandex.ru>
     [not found]     ` <831ti2yu1a.fsf@gnu.org>
     [not found]       ` <5565E28A.5040507@yandex.ru>
     [not found]         ` <83wpzuxbtd.fsf@gnu.org>
     [not found]           ` <5565E8AB.5020107@yandex.ru>
     [not found]             ` <83r3q2xa3q.fsf@gnu.org>
     [not found]               ` <5566583F.7020503@yandex.ru>
     [not found]                 ` <83h9qxxvo4.fsf@gnu.org>
     [not found]                   ` <5566EC49.8010907@yandex.ru>
     [not found]                     ` <837frsycly.fsf@gnu.org>
     [not found]                       ` <5567351E.7020006@yandex.ru>
     [not found]                         ` <83zj4owthp.fsf@gnu.org>
     [not found]                           ` <5567AE52.1000600@yandex.ru>
     [not found]                             ` <83fv6fx0nk.fsf@gnu.org>
     [not found]                               ` <55687241.5030200@yandex.ru>
     [not found]                                 ` <jwvvbfbbab7.fsf-monnier+emacsbugs@gnu.org>
     [not found]                                   ` <55689E02.5040605@yandex.ru>
     [not found]                                     ` <jwvpp5jb3au.fsf-monnier+emacsbugs@gnu.org>
     [not found]                                       ` <5568CD36.2030703@yandex.ru>
2015-05-29 21:41                                         ` etags completion table (was: bug#20629: 25.0.50; Regression: TAGS broken, can't find anything in C++ files) Stefan Monnier
2015-05-29 23:58                                           ` etags completion table Dmitry Gutov
2015-05-30  4:00                                             ` Stefan Monnier [this message]
2015-05-30 11:50                                               ` Dmitry Gutov
2015-05-31  0:57                                                 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvfv6era24.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).