Re: [Emacs-diffs] master ff9ddda: Simplify pre-write-conversion for utf-8-hfs coding system

Re: [Emacs-diffs] master ff9ddda: Simplify pre-write-conversion for utf-8-hfs coding system

[Stefan Monnier]

>  ;; Pre-write conversion for `utf-8-hfs'.
>  (defun ucs-normalize-hfs-nfd-pre-write-conversion (from to)
> -  (let ((old-buf (current-buffer)))
> -    (set-buffer (generate-new-buffer " *temp*"))
> -    (if (stringp from)
> -        (insert from)
> -      (insert-buffer-substring old-buf from to))
> -    (ucs-normalize-HFS-NFD-region (point-min) (point-max))
> -    nil))
> +  (ucs-normalize-HFS-NFD-region (point-min) (point-max)))
 
Could you add a comment explaining why it's OK to ignore `from` and `to`
here (as well as rename those args to `_from` and `_to` to make it
clear to the byte-compiler that we purposefully ignore them)?


        Stefan

Re: [Emacs-diffs] master ff9ddda: Simplify pre-write-conversion for utf-8-hfs coding system

[David Reitter]

On Jun 10, 2016, at 11:54 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> Could you add a comment explaining why it's OK to ignore `from` and `to`
> here (as well as rename those args to `_from` and `_to` to make it
> clear to the byte-compiler that we purposefully ignore them)?

I could, and I have.

Is it okay to commit this bug fix in emacs-25?
(Is cherry-picking of the two commits okay for this purpose?)

Re: [Emacs-diffs] master ff9ddda: Simplify pre-write-conversion for utf-8-hfs coding system

[Stefan Monnier]

>> Could you add a comment explaining why it's OK to ignore `from` and `to`
>> here (as well as rename those args to `_from` and `_to` to make it
>> clear to the byte-compiler that we purposefully ignore them)?
> I could, and I have.

I saw it.  Thanks very much.

> Is it okay to commit this bug fix in emacs-25?
> (Is cherry-picking of the two commits okay for this purpose?)

Sorry, no idea about this,


        Stefan

Re: [Emacs-diffs] master ff9ddda: Simplify pre-write-conversion for utf-8-hfs coding system

[Eli Zaretskii]

> From: David Reitter <david.reitter@gmail.com>
> Date: Mon, 13 Jun 2016 17:12:21 +0800
> Cc: emacs-devel@gnu.org
> 
> On Jun 10, 2016, at 11:54 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> 
> > Could you add a comment explaining why it's OK to ignore `from` and `to`
> > here (as well as rename those args to `_from` and `_to` to make it
> > clear to the byte-compiler that we purposefully ignore them)?
> 
> I could, and I have.

Thanks.

> Is it okay to commit this bug fix in emacs-25?

I thought we ended up realizing that there was some other factor at
work, which caused a simple 'insert' in a temporary buffer trigger
tool-bar update, and you were trying to find a simple recipe for
reproducing that?  I'd like to get to the bottom of that strange
phenomenon, because it could just be that the ucs-normalize change is
fixing the symptom, not the malady.

Did I miss something?