From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Compilation warnings in mouse.el Date: Wed, 13 Jul 2016 12:42:56 -0400 Message-ID: References: <8360scdzik.fsf@gnu.org> <87zipnzvo4.fsf@gmx.net> <8337nfcupy.fsf@gnu.org> <83inw9a9tl.fsf@gnu.org> <83wpkp8s9g.fsf@gnu.org> <83twft8qis.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1468428324 17853 80.91.229.3 (13 Jul 2016 16:45:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 Jul 2016 16:45:24 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 13 18:45:15 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bNNHd-00016a-PK for ged-emacs-devel@m.gmane.org; Wed, 13 Jul 2016 18:45:13 +0200 Original-Received: from localhost ([::1]:48969 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNNHd-0000Xp-1U for ged-emacs-devel@m.gmane.org; Wed, 13 Jul 2016 12:45:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59859) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNNFh-0007Tz-3Q for emacs-devel@gnu.org; Wed, 13 Jul 2016 12:43:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNNFc-0001N0-VE for emacs-devel@gnu.org; Wed, 13 Jul 2016 12:43:12 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:55523) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNNFc-0001Mw-OB for emacs-devel@gnu.org; Wed, 13 Jul 2016 12:43:08 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1bNNFZ-00083p-JW for emacs-devel@gnu.org; Wed, 13 Jul 2016 18:43:05 +0200 Original-Received: from 69-165-156-121.dsl.teksavvy.com ([69.165.156.121]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 13 Jul 2016 18:43:05 +0200 Original-Received: from monnier by 69-165-156-121.dsl.teksavvy.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 13 Jul 2016 18:43:05 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 13 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 69-165-156-121.dsl.teksavvy.com User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cancel-Lock: sha1:cHW8tjD4eJ6O7dZW9+pN81MM6WA= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205659 Archived-At: >> > If they must first check if there's a defgroup in the same file, and >> The byte-compiler will complain if a defcustom doesn't have a :group and >> there's no preceding defgroup (as was the case in the situation that >> started this discussion). So I don't think it's too much of a problem. > It's evidently a problem. Otherwise, I wouldn't have had to ask > Stephen to take care of those warnings. As long as Git doesn't grow an AI extension which automatically guesses that a ":group 'mouse" was meant here, I don't see how we could have a better solution. Stefan