From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 61f8c23 1/2: Minor advice.el fix Date: Tue, 13 Dec 2016 08:40:24 -0500 Message-ID: References: <20161212202151.21054.37035@vcs.savannah.gnu.org> <20161212202152.428192201BB@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1481636446 1855 195.159.176.226 (13 Dec 2016 13:40:46 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 13 Dec 2016 13:40:46 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: Glenn Morris To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 13 14:40:42 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGnJx-0008OG-Hu for ged-emacs-devel@m.gmane.org; Tue, 13 Dec 2016 14:40:41 +0100 Original-Received: from localhost ([::1]:38500 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGnK1-0001Uu-P3 for ged-emacs-devel@m.gmane.org; Tue, 13 Dec 2016 08:40:45 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43083) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGnJo-0001Sg-Da for emacs-devel@gnu.org; Tue, 13 Dec 2016 08:40:33 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGnJk-0005lI-0P for emacs-devel@gnu.org; Tue, 13 Dec 2016 08:40:32 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:11070) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cGnJj-0005js-QI; Tue, 13 Dec 2016 08:40:27 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0DVLgAu3EVY/+mQWxddGwEBAQMBAQEJAQEBgzgBAQEBAR+EW4VUnCgBlFaCCBmGAwQCAoIRQhIBAgEBAQEBAQFiKIRpBlYWCgMQCzQSFBgNiSatFItEAQEIAiWLGYUUhRUFj3yKapJziCeGOpIPJgMteBMOhXMgiS0BAQE X-IPAS-Result: A0DVLgAu3EVY/+mQWxddGwEBAQMBAQEJAQEBgzgBAQEBAR+EW4VUnCgBlFaCCBmGAwQCAoIRQhIBAgEBAQEBAQFiKIRpBlYWCgMQCzQSFBgNiSatFItEAQEIAiWLGYUUhRUFj3yKapJziCeGOpIPJgMteBMOhXMgiS0BAQE X-IronPort-AV: E=Sophos;i="5.33,749,1477972800"; d="scan'208";a="282493228" Original-Received: from 23-91-144-233.cpe.pppoe.ca (HELO pastel.home) ([23.91.144.233]) by smtp.teksavvy.com with ESMTP; 13 Dec 2016 08:40:25 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 4DE0465532; Tue, 13 Dec 2016 08:40:24 -0500 (EST) In-Reply-To: <20161212202152.428192201BB@vcs.savannah.gnu.org> (Glenn Morris's message of "Mon, 12 Dec 2016 20:21:52 +0000 (UTC)") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210400 Archived-At: > * lisp/emacs-lisp/advice.el (ad-preactivate-advice): > Avoid setting the function definition of nil. > This was happening during bootstrap of org-compat.el, > apparently due to eager macro expansion of code behind > a (featurep 'xemacs) test. Really, I think this business of "disallow fset of nil" is a big waste of time and will just lead to more pain than gain. There are umpteen different ways for the user to shoot himself in the foot. This one is not even fatal. Should we also disallow (fset 'car nil)? How 'bout (fset 'car #'cdr)? Stefan