From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Glenn Morris <rgm@gnu.org>
Subject: Re: [Emacs-diffs] master 61f8c23 1/2: Minor advice.el fix
Date: Tue, 13 Dec 2016 08:40:24 -0500 [thread overview]
Message-ID: <jwvfulsosoq.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20161212202152.428192201BB@vcs.savannah.gnu.org> (Glenn Morris's message of "Mon, 12 Dec 2016 20:21:52 +0000 (UTC)")
> * lisp/emacs-lisp/advice.el (ad-preactivate-advice):
> Avoid setting the function definition of nil.
> This was happening during bootstrap of org-compat.el,
> apparently due to eager macro expansion of code behind
> a (featurep 'xemacs) test.
Really, I think this business of "disallow fset of nil" is a big waste
of time and will just lead to more pain than gain.
There are umpteen different ways for the user to shoot himself in the
foot. This one is not even fatal.
Should we also disallow (fset 'car nil)? How 'bout (fset 'car #'cdr)?
Stefan
next parent reply other threads:[~2016-12-13 13:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161212202151.21054.37035@vcs.savannah.gnu.org>
[not found] ` <20161212202152.428192201BB@vcs.savannah.gnu.org>
2016-12-13 13:40 ` Stefan Monnier [this message]
2016-12-14 16:49 ` [Emacs-diffs] master 61f8c23 1/2: Minor advice.el fix Glenn Morris
2016-12-14 18:15 ` Stefan Monnier
2016-12-17 21:11 ` Philipp Stephani
2016-12-17 22:08 ` Stefan Monnier
2016-12-18 19:43 ` Philipp Stephani
2016-12-18 20:15 ` Stefan Monnier
2016-12-23 12:20 ` Philipp Stephani
2016-12-24 1:21 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvfulsosoq.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).