From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Gemini Lasswell <gazally@runbox.com>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master d895f6c: Fix Edebug specs for 'cl-defmethod' and 'defmethod'
Date: Wed, 10 May 2017 11:18:29 -0400 [thread overview]
Message-ID: <jwvfugcu4k1.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <87d3f658-f16a-9255-8115-2f071f9e518a@yandex.ru> (Dmitry Gutov's message of "Wed, 10 May 2017 17:24:33 +0300")
>>> - [ &optional keywordp ] ; this is key :before etc
>>> - list ; arguments
>>> + [ &optional keywordp ; this is key :before etc
>>> + &optional stringp ] ; :extra can be followed by a string
>>
>> Actually, there can be any number of non-lists between the function name
>> and the arg list. So it should probably be more like [ &rest atom ] or
>> something like that.
> By the way, do we want to support methods with zero arguments here? nil is
> an atom, and not a list.
IIRC CLOS does not allow 0-arg methods (and it allows nil as a qualifier),
whereas cl-defmethod uses `listp` to distinguish args from qualifiers,
so it doesn't allow nil as qualifier (tho I suspect it doesn't handle
a 0-arg method "correctly" either).
Stefan
next prev parent reply other threads:[~2017-05-10 15:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170502072023.14740.35996@vcs0.savannah.gnu.org>
[not found] ` <20170502072024.97B9A20CAB@vcs0.savannah.gnu.org>
2017-05-02 14:08 ` [Emacs-diffs] master d895f6c: Fix Edebug specs for 'cl-defmethod' and 'defmethod' Stefan Monnier
2017-05-03 21:46 ` Dmitry Gutov
2017-05-04 15:50 ` Stefan Monnier
2017-05-05 0:44 ` Dmitry Gutov
2017-05-10 14:24 ` Dmitry Gutov
2017-05-10 15:18 ` Stefan Monnier [this message]
2017-05-10 21:49 ` Dmitry Gutov
2017-05-10 21:54 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvfugcu4k1.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=gazally@runbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).