From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: [PATCH] * etc/NEWS: Document incompatibilities introduced by record types.
Date: Mon, 11 Dec 2017 22:21:34 -0500 [thread overview]
Message-ID: <jwvfu8gvdqm.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 20171211213729.41411-1-phst@google.com
> +** The introduction of record types (see below) brings several
> +incompatibilities:
> +*** The return value of 'type-of' is no longer a reliable indicator
> +for the type of an object. For example, a return value of 'integer'
> +now means that the object in question is either an integer or a record
> +named 'integer'.
No: if someone makes a record of type `integer` he's introduced a bug.
> Don't define record types
> +whose names clash with primitive type names.
Rather than "Don't" I'd say "it's a bug to ...".
> +*** The printed representation of a record named 'hash-table' now
> +clashes with the printed representation of a hash table. Don't define
> +record types named 'hash-table'.
This is subsumed by the previous "it's a bug to ...".
Clement said:
> Could we just reserve these names and make it an error to define such records?
> Or, could we make type-of return `record-foo` instead of `foo`?
It *is* an error. Just not one we bother to try and detect because it'd
imply making everyone pay all the time for the rare idiots who'll try to
create such a thing. There are plenty of ways for a user to shoot
himself in the foot, and we don't bother checking all of them, by a long
stretch: we only check those that have very serious consequences, or
that occur often, or that can be checked at no cost (e.g. it'd be fine to
make `cl-defstruct` reject names like `integer` or `hash-table` since
that's dirt cheap, but it's not a serious enough problem to justify
slowing down `make-record`).
Stefan
next prev parent reply other threads:[~2017-12-12 3:21 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 21:37 [PATCH] * etc/NEWS: Document incompatibilities introduced by record types Philipp Stephani
2017-12-11 22:25 ` Clément Pit-Claudel
2017-12-21 16:35 ` Philipp Stephani
2017-12-12 3:21 ` Stefan Monnier [this message]
2017-12-12 19:13 ` Clément Pit-Claudel
2017-12-12 20:45 ` Stefan Monnier
2017-12-13 23:00 ` Richard Stallman
2017-12-14 14:08 ` Stefan Monnier
2017-12-14 22:16 ` Richard Stallman
2017-12-14 23:41 ` Stefan Monnier
2017-12-15 21:25 ` Richard Stallman
2017-12-14 22:17 ` Richard Stallman
2017-12-22 10:06 ` Eli Zaretskii
2017-12-21 17:29 ` Philipp Stephani
2017-12-13 23:00 ` Richard Stallman
2017-12-14 14:07 ` Stefan Monnier
2017-12-12 22:06 ` Richard Stallman
2017-12-12 22:20 ` Stefan Monnier
2017-12-13 15:41 ` Sam Steingold
2017-12-13 16:30 ` Stefan Monnier
2017-12-13 23:03 ` Richard Stallman
2017-12-14 14:13 ` Stefan Monnier
2017-12-13 1:03 ` Stefan Monnier
2017-12-13 1:12 ` Noam Postavsky
2017-12-13 1:29 ` Stefan Monnier
2017-12-13 17:40 ` Stephen Leake
2017-12-13 23:02 ` Richard Stallman
2017-12-14 14:12 ` Stefan Monnier
2017-12-14 22:16 ` Richard Stallman
2017-12-14 22:16 ` Richard Stallman
2017-12-21 17:34 ` Philipp Stephani
2017-12-21 18:43 ` Stefan Monnier
2017-12-22 18:46 ` Richard Stallman
2017-12-22 19:39 ` [SUSPECTED SPAM] " Stefan Monnier
2017-12-23 14:56 ` Richard Stallman
2017-12-23 14:56 ` make-record Richard Stallman
2017-12-23 15:53 ` make-record Stefan Monnier
2017-12-24 20:35 ` make-record Richard Stallman
2017-12-26 2:43 ` make-record Stefan Monnier
2017-12-26 19:41 ` make-record Richard Stallman
2017-12-12 22:05 ` [PATCH] * etc/NEWS: Document incompatibilities introduced by record types Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvfu8gvdqm.fsf-monnier+gmane.emacs.devel@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).