From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 6fdc3fa: Support terminal focus notifications Date: Sat, 09 Jun 2018 11:33:20 -0400 Message-ID: References: <20180609055212.3056.85949@vcs0.savannah.gnu.org> <20180609055213.B7E0920498@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1528558854 5493 195.159.176.226 (9 Jun 2018 15:40:54 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 9 Jun 2018 15:40:54 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 09 17:40:50 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRfyz-0001Lg-VQ for ged-emacs-devel@m.gmane.org; Sat, 09 Jun 2018 17:40:50 +0200 Original-Received: from localhost ([::1]:40744 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRg16-000277-Q2 for ged-emacs-devel@m.gmane.org; Sat, 09 Jun 2018 11:43:00 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38602) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRfrt-0003ai-7P for emacs-devel@gnu.org; Sat, 09 Jun 2018 11:33:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRfrq-0002tO-4K for emacs-devel@gnu.org; Sat, 09 Jun 2018 11:33:29 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:59798) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRfrp-0002t1-VP for emacs-devel@gnu.org; Sat, 09 Jun 2018 11:33:26 -0400 Original-Received: from milanesa.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w59FXmnh014156; Sat, 9 Jun 2018 11:33:48 -0400 Original-Received: by milanesa.home (Postfix, from userid 20848) id CB426660F2; Sat, 9 Jun 2018 11:33:20 -0400 (EDT) In-Reply-To: <20180609055213.B7E0920498@vcs0.savannah.gnu.org> (Daniel Colascione's message of "Sat, 9 Jun 2018 01:52:13 -0400 (EDT)") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6304=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6304> : inlines <6687> : streams <1789193> : uri <2655292> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226138 Archived-At: > +(defun xterm-handle-focus-in () > + (interactive) > + (handle-focus-in)) > +(defun xterm-handle-focus-out () > + (interactive) > + (handle-focus-out)) Aka (defalias 'xterm-handle-focus-in #'handle-focus-in) (defalias 'xterm-handle-focus-out #'handle-focus-out) right? > +(define-key global-map [xterm-focus-in] #'xterm-handle-focus-in) > +(define-key global-map [xterm-focus-out] #'xterm-handle-focus-out) I think this deserves a comment explaining why we don't use the pre-existing `focus-in` and `focus-out` events and why we bind our events in global-map rather than in special-map (as is done for `focus-in/out` events). Stefan