From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master 61ad720: packages/nadvice: Fix advice-remove behaviour Date: Mon, 17 Sep 2018 09:54:07 -0400 Message-ID: References: <20180915233623.2746.56778@vcs0.savannah.gnu.org> <20180915233624.2285320442@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1537192370 20554 195.159.176.226 (17 Sep 2018 13:52:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Sep 2018 13:52:50 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Thomas Fitzsimmons To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 17 15:52:46 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g1txF-0005Ej-U7 for ged-emacs-devel@m.gmane.org; Mon, 17 Sep 2018 15:52:46 +0200 Original-Received: from localhost ([::1]:35705 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g1tzM-0005zg-Ii for ged-emacs-devel@m.gmane.org; Mon, 17 Sep 2018 09:54:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55155) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g1tyh-0005zX-T7 for emacs-devel@gnu.org; Mon, 17 Sep 2018 09:54:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g1tyc-0004r5-G6 for emacs-devel@gnu.org; Mon, 17 Sep 2018 09:54:15 -0400 Original-Received: from pmta31.teksavvy.com ([76.10.157.38]:32626) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1g1tya-0004jN-VR for emacs-devel@gnu.org; Mon, 17 Sep 2018 09:54:10 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2GFAQCqsZ9b/0mKs2tbHAEBAQQBAQoBA?= =?us-ascii?q?YFQggiBUhKISoNlX4tKAYIfIAGWF4F6CxOEUwQCAoNwIjQYAQMBAQEBAQECAgJ?= =?us-ascii?q?pKIU6BlYjEAs0EhQYDYVaphOKBYsEggCDbzWFS4ULApxECZAsgTUBhySGM5RPg?= =?us-ascii?q?UI5gVUzGggwgyiQbiONfQEB?= X-IPAS-Result: =?us-ascii?q?A2GFAQCqsZ9b/0mKs2tbHAEBAQQBAQoBAYFQggiBUhKISoN?= =?us-ascii?q?lX4tKAYIfIAGWF4F6CxOEUwQCAoNwIjQYAQMBAQEBAQECAgJpKIU6BlYjEAs0E?= =?us-ascii?q?hQYDYVaphOKBYsEggCDbzWFS4ULApxECZAsgTUBhySGM5RPgUI5gVUzGggwgyi?= =?us-ascii?q?QbiONfQEB?= X-IronPort-AV: E=Sophos;i="5.53,385,1531800000"; d="scan'208";a="45885686" Original-Received: from 107-179-138-73.cpe.teksavvy.com (HELO fmsmemgm.homelinux.net) ([107.179.138.73]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Sep 2018 09:54:07 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 2FCADAE1F5; Mon, 17 Sep 2018 09:54:07 -0400 (EDT) In-Reply-To: <20180915233624.2285320442@vcs0.savannah.gnu.org> (Thomas Fitzsimmons's message of "Sat, 15 Sep 2018 19:36:23 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 76.10.157.38 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:229894 Archived-At: > ;;;###autoload > (defun advice-remove (symbol function) > - (ad-remove-advice symbol 'around function) > - (ad-activate symbol)) > + ;; Just return nil if there is no advice, rather than signaling an > + ;; error. > + (condition-case nil > + (ad-remove-advice symbol 'around function) > + (error nil)) > + (condition-case nil > + (ad-activate symbol) > + (error nil))) Thanks, looks good'nuf Stefan