From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Nicolas Petton <nicolas@petton.fr>
Cc: Tom Tromey <tom@tromey.com>, Drew Adams <drew.adams@oracle.com>,
emacs-devel@gnu.org
Subject: Re: map-put! and (setf (map-elt ...) ..) on lists
Date: Tue, 18 Dec 2018 08:56:04 -0500 [thread overview]
Message-ID: <jwvftuvhrja.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87bm5jm9eu.fsf@petton.fr> (Nicolas Petton's message of "Tue, 18 Dec 2018 11:11:37 +0100")
>> map-put!:
>>
>> Associate KEY with VALUE in MAP and return VALUE.
>> If KEY is already present in MAP, replace the associated value
>> with VALUE.
Not sure which version you were looking at, but what I see is:
"Associate KEY with VALUE in MAP.
If KEY is already present in MAP, replace the associated value
with VALUE.
This operates by modifying MAP in place.
If it cannot do that, it signals the `map-not-inplace' error.
If you want to insert an element without modifying MAP, use `map-insert'."
> As I said, I like Stefan's approach, but if everybody else dislike it,
> and if you think it's not idiomatic Elisp, then let's change the name.
>
> Stefan, would it be ok with you?
As I said, I like Scheme's ! convention, but I really don't care very
much about the name: I think normal code should never call this function
directly and should use `(setf (map-elt ...) ..)` instead anyway!
So, even a longwinded name would be perfectly fine.
Stefan
next prev parent reply other threads:[~2018-12-18 13:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 17:32 map-put! and (setf (map-elt ...) ..) on lists Stefan Monnier
2018-12-16 16:32 ` Tom Tromey
2018-12-16 17:37 ` Drew Adams
2018-12-16 18:20 ` Stefan Monnier
2018-12-16 23:06 ` Tom Tromey
2018-12-17 3:16 ` Stefan Monnier
2018-12-17 4:08 ` Stefan Monnier
2018-12-17 11:41 ` Nicolas Petton
2018-12-17 16:06 ` Eli Zaretskii
2018-12-17 16:07 ` Drew Adams
2018-12-18 10:11 ` Nicolas Petton
2018-12-18 13:56 ` Stefan Monnier [this message]
2018-12-18 15:42 ` Drew Adams
2018-12-18 15:34 ` Drew Adams
2018-12-18 15:47 ` Stefan Monnier
2018-12-18 16:34 ` Nicolas Petton
2018-12-18 17:41 ` Drew Adams
2018-12-18 20:44 ` Nicolas Petton
2018-12-16 18:21 ` Stefan Monnier
2018-12-17 11:38 ` Nicolas Petton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvftuvhrja.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=nicolas@petton.fr \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).