From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Scrolling commands and skipping redisplay, was: Re: emacs rendering comparisson between emacs23 and emacs26.3 Date: Fri, 10 Apr 2020 13:46:22 -0400 Message-ID: References: <20200403174757.GA8266@ACM> <20200405195753.GG5049@ACM> <542b48ba-4dfa-820f-ba50-4b147ab6d8e2@yandex.ru> <0a5f70aa-4985-8f8d-81d6-6ac4a60a94f9@yandex.ru> <838sj8sphk.fsf@gnu.org> <834ktwsmfw.fsf@gnu.org> <83imibqsmm.fsf@gnu.org> <478c2aab-a5fc-61c2-02e2-2d9846b95273@yandex.ru> <83v9m9nltx.fsf@gnu.org> <4c5ebff1-39ab-3d63-6118-42befc93b862@yandex.ru> <6914ebb2-2dfa-efdc-1181-c42259219bca@yandex.ru> <83zhbjna0q.fsf@gnu.org> <903b7d31-bd0e-e2dc-a981-d090ed959ccb@yandex.ru> <83pncfmpme.fsf@gnu.org> <94ee576f-ff26-cad9-3e22-b75299ff9cdb@yandex.ru> <37afe0b1-7763-4d63-3dc2-5b20415207fe@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="84878"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: rms@gnu.org, emacs-devel@gnu.org, rudalics@gmx.at, rrandresf@gmail.com, acm@muc.de, Eli Zaretskii To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 10 19:47:12 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jMxkG-000Lx7-3D for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Apr 2020 19:47:12 +0200 Original-Received: from localhost ([::1]:37420 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jMxkF-0007Gi-3a for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Apr 2020 13:47:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49442) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jMxjh-0006k2-G5 for emacs-devel@gnu.org; Fri, 10 Apr 2020 13:46:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jMxjf-0000IA-3Z for emacs-devel@gnu.org; Fri, 10 Apr 2020 13:46:35 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:54537) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jMxjd-0000Fn-Fr; Fri, 10 Apr 2020 13:46:33 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7D6E381247; Fri, 10 Apr 2020 13:46:32 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B7B4B80DFC; Fri, 10 Apr 2020 13:46:23 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1586540783; bh=AdILwFwrKm2LXuAHA3s0UzXE9cC8ceZmyrbj5GZpaXM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=KSpKR1ly1vofH8M3grfNtuqFWf5L5hsWiNrVl45p56Yt+ARNigzk2uumf9hcnyMDR NODzLUO/y3pUD0nwdLZY7l+tgl0/kz6WeLt0sTE+0AFxUZ4euXHJUQuBLSC9sLD8yL M06NI0b6eVHx3eP2gDQCQCsfZEt7BjWuQO+rrRezFMxC27zs7If189XTqTjPNpsR42 QW/XUiAV71TasUGPiGWRvQjOV386/QFRGllhUWV8VCU1PRRX2UyqS1v6akj+MEtA+u s79ZAfkYcuuszSoZqszQyPJYWxAlHBdry7Qrd7kKNTsPG+PhsOqNbmOOgU0CBW3ej1 P15mylX2NGjrA== Original-Received: from alfajor (unknown [104.247.241.114]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5982E120172; Fri, 10 Apr 2020 13:46:23 -0400 (EDT) In-Reply-To: <37afe0b1-7763-4d63-3dc2-5b20415207fe@yandex.ru> (Dmitry Gutov's message of "Fri, 10 Apr 2020 20:23:14 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246785 Archived-At: > When the last repetition is executed, the behavior seems fine already if the > value is 0. What I see is "flickering" during scrolling, while C-v is still > pressed. Hmmm... I don't know why you see "flickering" during the scrolling, indeed. And I'm surprised you don't see "flickering" on the last repetition: the way jit-lock-defer-time works, when input-pending-p is non-nil, jit-lock marks the chunk as fontified (which is a lie), and this chunk will always go past `window-end`, so on the last repetition the beginning of the window is not passed to jit-lock at all (because it was part of the last chunk of the previous call to jit-lock, with input-pending = true), and it only gets fontified a bit later via the timer. That's one of the main advantages of the way `fast-but-imprecise-scrolling` works: it doesn't lie about having fontified that chunk. Along the lines of what you proposed, I just tried the patch below, which is a bit like (setq jit-lock-defer-mode 0) but without the idle timer. It's not quite right either, tho (e.g. `emacs -Q src/xdisp.c` fails to font-lock the initial window, tho it does get font-locked as soon as I move the cursor). Stefan diff --git a/src/xdisp.c b/src/xdisp.c index 193cc372b0..230e8e2182 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -4097,6 +4097,7 @@ handle_fontified_prop (struct it *it) { Lisp_Object prop, pos; enum prop_handled handled = HANDLED_NORMALLY; + extern bool input_was_pending; if (!NILP (Vmemory_full)) return handled; @@ -4108,6 +4109,7 @@ handle_fontified_prop (struct it *it) if (!STRINGP (it->string) && it->s == NULL && !NILP (Vfontification_functions) + && !input_was_pending && !NILP (Vrun_hooks) && (pos = make_fixnum (IT_CHARPOS (*it)), prop = Fget_char_property (pos, Qfontified, Qnil),