From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: bug-reference.el: Allow custom handlers for opening URLs Date: Mon, 04 May 2020 11:32:56 -0400 Message-ID: References: <87h7wx4d24.fsf@gnu.org> <87d07l3utr.fsf@gnu.org> <87tv0w9gw6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="99648"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Yuri Khan To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 04 17:44:00 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jVdGB-000PpM-UA for ged-emacs-devel@m.gmane-mx.org; Mon, 04 May 2020 17:43:59 +0200 Original-Received: from localhost ([::1]:60244 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVdGA-0004gs-Tn for ged-emacs-devel@m.gmane-mx.org; Mon, 04 May 2020 11:43:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60902) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVd5b-0001Fp-2u for emacs-devel@gnu.org; Mon, 04 May 2020 11:33:03 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:56871) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVd5Z-0000EK-FK for emacs-devel@gnu.org; Mon, 04 May 2020 11:33:02 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id CCE3880B2A; Mon, 4 May 2020 11:32:59 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 78A90805BA; Mon, 4 May 2020 11:32:57 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1588606377; bh=V0hWta8mouuQKVdrJIoSY21/kz15PAjomkBAzT9dXTU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=XS5t5NebJHVi/Shr/+wn0zd/kxKsMdb0T7GtDVn7OvWeLH9ncv6h3XP5540kIltS3 5TfCBhJ/XCQfQf7P+jAC00veRb3i43eeae3sxehhVHgBjCvOTM2GzsFF+8R4AnznM7 TeaSrALg+Gywr/UIuHamtT9yIbFiaQcmn3dwi4moHnJIWx9oNBBUgw6XnDdb73dCVN bScECOXsaYoDG8mixKGU5TPeCCZfemgcCEiHeeL7gKi5AzOZ98jJFnwoZM59L+Hzup LAS1Fq5iluUk3NSUKUEuzJZPnSUF5wsNp/8I0JcpwE49QEeBVupur7LmPEI2OMcaRS MCvnfAqmnVzLg== Original-Received: from alfajor (unknown [216.154.3.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4550B120432; Mon, 4 May 2020 11:32:57 -0400 (EDT) In-Reply-To: <87tv0w9gw6.fsf@gnu.org> (Tassilo Horn's message of "Mon, 04 May 2020 11:41:13 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 11:09:38 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:248849 Archived-At: > And when hacking that up, I've seen that this feature is already > implemented! > > The value of `browse-url-browser-function' may already be a (REGEXP > . FUNCTION) alist itself and then it works the same way as my new > `browse-url-handlers'. Hmm... right. Ideally we should have 2 places to specify those redirections: one autoload-set by packages to change the default behavior, and one custom-set by the user to override that default behavior. But if we use `browse-url-browser-function` as the user-override, then as soon as the user sets it to `browse-url-firefox` it would override all the defaults :-( So we still need to deprecate this old hack on `browse-url-browser-function`. > But removing the alist from `browse-url--browser-defcustom-type' would > break the customize interface if the user's value is indeed an alist... > So is there a better way to deprecate a single choice of a defcustom > type? Just writing that in the docstring? Good question, hopefully someone else knows. Stefan