unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Yuri Khan <yuri.v.khan@gmail.com>
Subject: Re: bug-reference.el: Allow custom handlers for opening URLs
Date: Mon, 04 May 2020 11:32:56 -0400	[thread overview]
Message-ID: <jwvftcfafgo.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87tv0w9gw6.fsf@gnu.org> (Tassilo Horn's message of "Mon, 04 May 2020 11:41:13 +0200")

> And when hacking that up, I've seen that this feature is already
> implemented!
>
> The value of `browse-url-browser-function' may already be a (REGEXP
> . FUNCTION) alist itself and then it works the same way as my new
> `browse-url-handlers'.

Hmm... right.  Ideally we should have 2 places to specify those
redirections: one autoload-set by packages to change the default
behavior, and one custom-set by the user to override that
default behavior.

But if we use `browse-url-browser-function` as the user-override, then
as soon as the user sets it to `browse-url-firefox` it would override
all the defaults :-(

So we still need to deprecate this old hack on `browse-url-browser-function`.

> But removing the alist from `browse-url--browser-defcustom-type' would
> break the customize interface if the user's value is indeed an alist...
> So is there a better way to deprecate a single choice of a defcustom
> type?  Just writing that in the docstring?

Good question, hopefully someone else knows.


        Stefan




  reply	other threads:[~2020-05-04 15:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-03  8:50 bug-reference.el: Allow custom handlers for opening URLs Tassilo Horn
2020-05-03 14:44 ` Stefan Monnier
2020-05-03 15:24   ` Tassilo Horn
2020-05-03 20:39     ` Stefan Monnier
2020-05-04  9:41       ` Tassilo Horn
2020-05-04 15:32         ` Stefan Monnier [this message]
2020-05-04 17:09           ` Tassilo Horn
2020-05-04 18:54             ` Stefan Monnier
2020-05-05  7:06               ` Tassilo Horn
2020-05-05 13:49                 ` Stefan Monnier
2020-05-05 15:51                   ` Tassilo Horn
2020-05-05 17:44                     ` Stefan Monnier
2020-05-05 19:48                       ` browse-url.el: Custom handlers for certain URLs (was: bug-reference.el: Allow custom handlers for opening URLs) Tassilo Horn
2020-05-04  6:52     ` bug-reference.el: Allow custom handlers for opening URLs Yuri Khan
2020-05-05 19:55 ` Arash Esbati

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvftcfafgo.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=yuri.v.khan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).