unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "João Távora" <joaotavora@gmail.com>
Cc: emacs-devel@gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: Re: scratch/eldoc-xref-project-gnu-elpa-core-packages b1631cd: Turn Eldoc, Xref and Project into GNU ELPA :core packages
Date: Mon, 11 May 2020 19:17:39 -0400	[thread overview]
Message-ID: <jwvftc65ay2.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87ftc6f7ex.fsf@gmail.com> ("João Távora"'s message of "Mon, 11 May 2020 23:12:06 +0100")

> 1. xref and project.el have a cyclic dependency.  xref.el depends
>   (properly) on project.el but it seems project.el also depends on
>   xref.el.
>
>      (defun project--files-in-directory (dir ignores &optional files)
>        (require 'find-dired)
>        (require 'xref)
>        (defvar find-name-arg)
>
>    How should I fix this? Any ideas? Or should I be creative?

IIUC a significant part of project's functionality works fine without
xref, so you could consider that project does not Package-Require
`xref`.

Also it's worth checking if it depend on a *recent* version of xref, or
if it also work with the xref that comes with Emacs-26 or even Emacs-25.

Another option is to bundle them into a single package (`:core` packages
can be composed of several files, see `soap-client` for an example).

> 2. It'd be nice if both xref.el and project.el were available for Emacs
>    26.3.  But project.el in Emacs master depends on fileloop.el,

This dependency is of no real importance: it's only used to provide the
two commands `project-search` and `project-query-replace-regexp` for
which there are many alternatives anyway.  So I wouldn't worry about it.
We could simply change the code to test (fboundp
'fileloop-initialize-replace) and signal a cleaner error (mentioning
that these commands only work in Emacs≥27) than "void-function".


        Stefan




  parent reply	other threads:[~2020-05-11 23:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200511214134.32634.30981@vcs0.savannah.gnu.org>
     [not found] ` <20200511214135.F14AF20A23@vcs0.savannah.gnu.org>
2020-05-11 21:54   ` scratch/eldoc-xref-project-gnu-elpa-core-packages b1631cd: Turn Eldoc, Xref and Project into GNU ELPA :core packages Dmitry Gutov
2020-05-11 22:12     ` João Távora
2020-05-11 22:21       ` Dmitry Gutov
2020-05-11 22:36         ` João Távora
2020-05-11 23:17       ` Stefan Monnier [this message]
2020-05-11 23:25         ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvftc65ay2.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=joaotavora@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).