From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: master f0b0105: Hoist some byte-code checking out of eval
Date: Wed, 20 May 2020 22:30:11 -0400 [thread overview]
Message-ID: <jwvftbuqaws.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <51264591-6e62-e2df-2571-181679fc90f9@cs.ucla.edu> (Paul Eggert's message of "Wed, 20 May 2020 17:54:35 -0700")
>> My point is that 99% of the calls to `exec_byte_code` don't go through
>> `Fbyte_code`.
> Those other calls are also supposed to arrange for the relevant checks to be
> done, typically when the objects given to exec_byte_code were created. It
> saves some time to do the checks once on object creation rather than every
> time the byte code is called.
I understand, but looking at the patch and the comment message, I see
that you moved the checks from exec_byte_code to Fbyte_code and moved
duplicated *some* of the checks in make_byte_code but not all of them.
I probably missed something,
Stefan
next prev parent reply other threads:[~2020-05-21 2:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200520062521.6783.95407@vcs0.savannah.gnu.org>
[not found] ` <20200520062523.3EF4A20AEB@vcs0.savannah.gnu.org>
2020-05-20 12:03 ` master f0b0105: Hoist some byte-code checking out of eval Stefan Monnier
2020-05-20 21:21 ` Paul Eggert
2020-05-20 23:21 ` Stefan Monnier
2020-05-21 0:54 ` Paul Eggert
2020-05-21 2:30 ` Stefan Monnier [this message]
2020-05-21 5:26 ` Paul Eggert
2020-05-21 13:35 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvftbuqaws.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).