From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master c5cf630: Don't clobber match data in utf-8-hfs conversion (bug#41445) Date: Thu, 28 May 2020 12:27:49 -0400 Message-ID: References: <20200527143042.599.17398@vcs0.savannah.gnu.org> <20200527143043.D0DDC20A2C@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="12816"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Emacs developers To: Mattias =?windows-1252?Q?Engdeg=E5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 28 18:28:49 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jeLOi-0003Di-Vo for ged-emacs-devel@m.gmane-mx.org; Thu, 28 May 2020 18:28:48 +0200 Original-Received: from localhost ([::1]:34070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeLOh-0002lV-WF for ged-emacs-devel@m.gmane-mx.org; Thu, 28 May 2020 12:28:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeLNr-0001M0-V0 for emacs-devel@gnu.org; Thu, 28 May 2020 12:27:55 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:33738) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeLNp-0006jF-K7 for emacs-devel@gnu.org; Thu, 28 May 2020 12:27:54 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 26255806F7; Thu, 28 May 2020 12:27:52 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7C30980541; Thu, 28 May 2020 12:27:50 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1590683270; bh=5idfMT9y8tym/hlnECcNhLtpR6CdekbSoyvk+FbiBqI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=aklM01YyUN6lg3xeMv4iZf4xNvhkbChnCqsQDO8XVAaSyJe+YyS2GaTbQ4lL6gcfN E47zUiT7GxSlhBvtBk5K1z9TD2Q2Ep8EdHtKoZ6VRIco3CsOSJnWND/RoTsyOl82hF ij7ZyLOsqJsnGpKoHGUGil80fjeH24Iss7zq/PuVEvNSOie/ppgh/xOX9RU5fPPfXG /cYqWD39C5SumH/gss5OqZtm4MNzc6waSdyoF+miWF0QS6oOkUC1wsHifFo8OfApT3 gWWV5VIhkvHsnvDBfjZK6bO4SkmeC16GaA66N6XavcNqBQg1ajfP+YC5t/Qmk6S9yy +LICi/UytvCkg== Original-Received: from alfajor (unknown [216.154.27.250]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 50E37120554; Thu, 28 May 2020 12:27:50 -0400 (EDT) In-Reply-To: ("Mattias =?windows-1252?Q?Engdeg=E5rd=22's?= message of "Thu, 28 May 2020 16:56:59 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/28 12:24:56 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:251556 Archived-At: >> 1- document that `(en|de)code-coding-string` preserve the match-data. >> 2- document in `define-coding-system` that the pre/post-conversion >> functions should preserve the match-data. > > Very reasonable; now done on master. > We could perhaps say the same thing about {en,de}code-coding-region but > I didn't do that in this change. `(en|de)code-coding-region` run various other (buffer-modification) hooks, so I don't think anyone currently relies on them preserving the match-data (and it would be a wrong assumption), also because those function can change buffer positions making the match-data invalid even if it's not modified. So I don't see any need to declare that those functions preserve the match-data. Stefan