From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 2e090da: Revert commit 1f44a776729adf9c6468a76f8310616fde62eeaa for Flymake. Date: Sun, 25 Oct 2020 09:59:05 -0400 Message-ID: References: <20201025101403.1168.4440@vcs0.savannah.gnu.org> <20201025101404.7EBE2204DA@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39479"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 25 14:59:48 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kWgYl-000AB6-IV for ged-emacs-devel@m.gmane-mx.org; Sun, 25 Oct 2020 14:59:47 +0100 Original-Received: from localhost ([::1]:37850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWgYk-0007SI-IS for ged-emacs-devel@m.gmane-mx.org; Sun, 25 Oct 2020 09:59:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47442) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWgYD-00070U-0L for emacs-devel@gnu.org; Sun, 25 Oct 2020 09:59:13 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:16092) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWgYB-00073o-0X for emacs-devel@gnu.org; Sun, 25 Oct 2020 09:59:12 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id AC7AC4405B9; Sun, 25 Oct 2020 09:59:09 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E6F794403A2; Sun, 25 Oct 2020 09:59:06 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1603634346; bh=s/OP2at7F8+yQme3+rJ1rGQwOQyi6N5MkyGEetJG8nQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=XJ7LuB1GPO9nBk7JHgXqr35FP29NfYWghJhGo0S43X1sGxdH740sBXHGZxbRi6U+/ uEUScUsHUtzLtvrJ1dTzEH7P1uDU0ILA63RKAU5YfoLbw9gQWEcKhrFjwYdM45DZU+ 5g1ADYkQYLfiJmv2vUn8s2GXxvHE7iuk5DmiYxLx5bCRO2RuEbEXvy01HXGSCMsN7b XzLVn3WoasOz1IHdewXn9w2MHl1ZfSFgoXsdjeZAfBeB0RUqEf7nAEk1K3faLUYLXT FJ6vnDS6n0Jpp5+vmyjrwSrkUqbvJ4/5wMnWD/5eD2c8TB2+qoz11pLi/er9GEVd3e RlVKIUuJejGmg== Original-Received: from alfajor (unknown [157.52.9.240]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AF86C120284; Sun, 25 Oct 2020 09:59:06 -0400 (EDT) In-Reply-To: <20201025101404.7EBE2204DA@vcs0.savannah.gnu.org> (Philipp Stephani's message of "Sun, 25 Oct 2020 06:14:04 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/25 09:50:24 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258449 Archived-At: > Revert commit 1f44a776729adf9c6468a76f8310616fde62eeaa for Flymake. > Flymake supports all Emacs versions back to 26.1, so it can=E2=80=99t= use > =E2=80=98ert-resource-file=E2=80=99. > * test/lisp/progmodes/flymake-tests.el (flymake-tests-data-directory): > Recreate. > (flymake-tests--call-with-fixture): Stop using =E2=80=98ert-resource-= file=E2=80=99. It's common for a package to say "require Emacs version NN.MM" but to provide extra features on more recent Emacsen. And the tests can definitely fall into the category of extra features. Better yet: the GNU ELPA package does not even include the flymake-tests.el= file. Stefan