From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: What's the line length limit in the Emacs codebase? Date: Wed, 23 Dec 2020 11:55:23 -0500 Message-ID: References: <83wnx8pm0e.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20623"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Philipp Stephani , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 23 17:56:02 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ks7Qg-0005GT-DL for ged-emacs-devel@m.gmane-mx.org; Wed, 23 Dec 2020 17:56:02 +0100 Original-Received: from localhost ([::1]:34902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ks7Qf-0001W6-EO for ged-emacs-devel@m.gmane-mx.org; Wed, 23 Dec 2020 11:56:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40580) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ks7Q9-00014R-Mg for emacs-devel@gnu.org; Wed, 23 Dec 2020 11:55:29 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:52116) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ks7Q7-0007Yj-5C; Wed, 23 Dec 2020 11:55:28 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 79BF2100486; Wed, 23 Dec 2020 11:55:25 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1854F1002B8; Wed, 23 Dec 2020 11:55:24 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1608742524; bh=swainUQG21Yz3duniKClKNDS1nZ8X2K0fKQMnXITSJ4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=CZZH6ys9BlnChj3qCpC/ielU6KeDSrBnBk8HNLFKLh15FiTo4CBRUOgtYq7juALZl MuWnZv0H7cptJlDuRQe2rKv3rgDeVX0vfatw9Q2ZxbjwN7lHNCNqPmfIYaCj1QdiOV NSI2320hE11L4tGfhklWbOSpqjAkombscsuwdAAvwJUVWBOfu2TeDytER11HiGfNTo lV7PX8VHW+zYt5xxaEW2LNCpn5bEvMHLULPmnTUFqBMYrYN677yfD4vumplCcg+s0Q rPEzSj9XE8BXqmr6YNsqn6Y4uRSr9lCWu7rEIqsjVgRt19jurAKq4hhVr5/GskXWeI csvH65Mvnmn9w== Original-Received: from alfajor (69-165-136-52.dsl.teksavvy.com [69.165.136.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D5E921202A5; Wed, 23 Dec 2020 11:55:23 -0500 (EST) In-Reply-To: <83wnx8pm0e.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 23 Dec 2020 17:42:09 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:261619 Archived-At: >> There seem to be conflicting settings for the line length limit in the >> Emacs codebase: .dir-locals.el sets fill-column to 70, but large areas >> of the source code (including comments) seem to use 80. Can we pick >> one value and use it consistently (for new/changed code)? > > 70 is it, we just don't necessarily enforce it religously. > > Where did you see significant deviations from that standard? Indeed. I'd say that we it's a kind of progressive limit: - it's OK to have all lines =E2=89=A4 70-columns wide - it's not OK to have most lines >70-columns - we tolerate reaching the area between 70 and 80 columns every once in a while, tho. - =E2=89=A580 columns OTOH should really be rare, limited to the exceptional cases where the alternative is really worse. Stefan