From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 6458e16: New mode outline-cycle-minor-mode with Orgmode-like TAB cycling on headings Date: Thu, 04 Mar 2021 17:57:04 -0500 Message-ID: References: <20210303191236.24697.93201@vcs0.savannah.gnu.org> <20210303191237.2B2D720E1B@vcs0.savannah.gnu.org> <87zgzkug5d.fsf@mail.linkov.net> <9d5801ee-7b73-9312-063e-5cefe227123e@grinta.net> <87zgzi69zr.fsf@mail.linkov.net> <9a88bc11-2325-b4cb-5253-4580134234d3@grinta.net> <87tupqoe2h.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13512"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Daniele Nicolodi , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 04 23:59:52 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHwwi-0003Rc-8P for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Mar 2021 23:59:52 +0100 Original-Received: from localhost ([::1]:37506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHwwh-0003VL-At for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Mar 2021 17:59:51 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHwu6-0008Fq-Ga for emacs-devel@gnu.org; Thu, 04 Mar 2021 17:57:11 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:16412) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHwu4-0008MD-EL for emacs-devel@gnu.org; Thu, 04 Mar 2021 17:57:09 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id CC64480C41; Thu, 4 Mar 2021 17:57:06 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 3EF3980057; Thu, 4 Mar 2021 17:57:05 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1614898625; bh=Fg/CFgKLnP8PKojvo/bc2xV4ezNpPvHHjVyPSJ6xhJA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=iZbkeUGvVgw3oOvV5NdsC2wPTosnQUvKjdSlOOaNx7j5tQj+JTuUGrS9ojtEEkjtk 1PvUW9/7QcnHBW1iLc15CQoViQERs7mKYMAsjswlh4T/hu5AoXRwHNHNl8Iq9Xb+Pz BvWkzlfXN02xzGZb+eS7FgDrkRmtk84yeiE17J0AZULxdDxUfXvtVWTEGPtxqfJcUz Pi9aJi41d4L9l/p+kFFDaxfIRj/S7XliTYa4Drgmder/jnbzDwU1CV/MfjVUI/OAdG VpVU8X+qbmtTTzGmXJNulZahC8ieV0gANFQDMD1ylyWtpCgGjAjkUpxrNjQlzvgS1D WLN3MomBRzodw== Original-Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0B30E1203E2; Thu, 4 Mar 2021 17:57:04 -0500 (EST) In-Reply-To: <87tupqoe2h.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 04 Mar 2021 22:35:06 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265995 Archived-At: > This is what I see: when a line is already fontified e.g. as comments by > the current major mode, then outline-mirror-mode doesn't put outline faces > over it. That is not quite right: once you fix the laxmatch-vs-override confusion, your code does put the face on it. The problem is that by default those faces only use colors to distinguish the headings level. FWIW, I think this is a mistake in outline.el: the faces should mostly change the *height*. That would interact much better with things like font-lock-comment-face as well. Stefan