From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: defadvice bug or something else? Date: Wed, 28 Apr 2021 22:07:09 -0400 Message-ID: References: <87fsz9swcf.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24045"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Tim Cross Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 29 04:08:51 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbw6l-00064q-49 for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Apr 2021 04:08:51 +0200 Original-Received: from localhost ([::1]:58978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbw6j-0005Vy-Ii for ged-emacs-devel@m.gmane-mx.org; Wed, 28 Apr 2021 22:08:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37946) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbw5Q-00053o-7Y for emacs-devel@gnu.org; Wed, 28 Apr 2021 22:07:28 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:45930) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbw5L-0001Yl-7F for emacs-devel@gnu.org; Wed, 28 Apr 2021 22:07:27 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2E6908005D; Wed, 28 Apr 2021 22:07:21 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B0CB580385; Wed, 28 Apr 2021 22:07:10 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1619662030; bh=Y0MpwvwBh6aaBv9OiUw4qxc2TyJCqjSmVw2ifcVGU4U=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=MWyHusCmwlx/NsLdZcF2CBDugpDQIuMNNrakB1GgPv//jJVrSO6oyP9+kstSnSzKu 4F7fNZmgBygAv4H8r043KAlhnR8Iqd/QYh8vJ1y2522PU19RWDNd+ufK1CfmYQ30xs hxNcW8inrOl1xXYjM0c4CylHuRxGnoZxSoxCyiM/s5A6umEkhqTJccZ/POq5pHVWnF 5ButgTx/pDwp90dLTChoTj1txXAxiYSJFbMJE0NufftDZ+GF6df78ZbMJ7OpqU1Un5 2D9/dGm86rlQ4qGCn97agUCF4E8fQCEshxrp++mNiQfvyX3VZTGb2IRe1joHs3hgkK H3QdPlAOi4/TA== Original-Received: from alfajor (unknown [157.52.10.47]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 80532120624; Wed, 28 Apr 2021 22:07:10 -0400 (EDT) In-Reply-To: <87fsz9swcf.fsf@gmail.com> (Tim Cross's message of "Thu, 29 Apr 2021 11:17:09 +1000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268594 Archived-At: > `(defadvice ,f (after emacspeak pre act comp) > (message "scroll advice: start = %d end = %d diff = %d" > (window-start) > (window-end) > (- (window-end) (window-start)))))) I think this may return outdated values for `window-end` because it is run before the window end position has been recomputed by redisplay. If that's not what you want, then you need to pass non-nil value for the `update` argument. Stefan