From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: "after" variable watchers Date: Mon, 17 May 2021 14:54:27 -0400 Message-ID: References: <83lf8du09t.fsf@gnu.org> <3431d752-559a-7d33-e2fb-2d81dd6cc794@gmx.at> <83wnrxryft.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22418"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: rudalics@gmx.at, npostavs@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 17 21:32:07 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1liiyF-0005fF-5z for ged-emacs-devel@m.gmane-mx.org; Mon, 17 May 2021 21:32:07 +0200 Original-Received: from localhost ([::1]:52080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liiyE-0007Pk-31 for ged-emacs-devel@m.gmane-mx.org; Mon, 17 May 2021 15:32:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liiNu-0008TQ-Lr for emacs-devel@gnu.org; Mon, 17 May 2021 14:54:34 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:49015) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liiNr-0002iE-Hv; Mon, 17 May 2021 14:54:33 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id DC9F0440BF2; Mon, 17 May 2021 14:54:29 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B4982440CE6; Mon, 17 May 2021 14:54:28 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1621277668; bh=fr0/8bVU33zkwQeJvUiBLkg9a9aI9pvOrzaIexMuEIY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=DP4Lkp5SFaBdUPd9/iNs2QztIs9cSywPyPsaR8gTNFZW/zdekOl2lIkYxqWDR+NTK cHOa5j/XpuIPaFWEwRpj8i88wMzW277WDtETuEsOEXNYF/BVmDyb1zu/uphRCypbUI MK98L1JFAp9k6PoA7HIt3Ho+Ch3UgfGIQ0ueP9ufq8U6av6lLhJCJeJxyS9GIlhz7P bxGuwd5fPfVffL9zv/QHJhncs+rzI+kkfzqzl6vy/vzHnr0IfxAr15Jr1Z2NPwAbaO 2Z2LLzctjNCFZrpZhytKmteOgXev22OX4KtFL3hXw7hlKDo1RnXEZMSGMBWjwBo3cB UMTAqE/RJ4uHg== Original-Received: from alfajor (76-10-140-76.dsl.teksavvy.com [76.10.140.76]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7FCA7120197; Mon, 17 May 2021 14:54:28 -0400 (EDT) In-Reply-To: <83wnrxryft.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 17 May 2021 21:45:58 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269423 Archived-At: >> > window_updeco_window is called indirectly from all places that change a >> > window's decorations, font or size. >> >> Would it make sense to call it more lazily, e.g. as part of redisplay >> (basically, the watchpoints would just set some dirty bits and then at >> the beginning of redisplay you'd then run `window_updeco_window` on >> those windows with the dirty bit set)? > > You don't need a watcher to set flags on windows. Each change in the > dimensions of windows and their decorations is already preformed by > functions. You're asking for a watcher, right? I's telling you to make this watcher set a dirty flag rather than immediately reacting to that variable value's change. Stefan