From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/cape 45fe322c99: cape-company-to-capf: Remove (t . cape--done) from unread-command-events (Fix #23) Date: Sat, 15 Jan 2022 10:44:23 -0500 Message-ID: References: <164225863766.32675.11430495138124328078@vcs2.savannah.gnu.org> <20220115145717.E3D2BC0DA2E@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8192"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Daniel Mendler To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 15 16:46:21 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8lG0-0001rg-Ch for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Jan 2022 16:46:20 +0100 Original-Received: from localhost ([::1]:53918 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8lFy-0001LY-UT for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Jan 2022 10:46:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55454) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8lEF-0000Y7-Rh for emacs-devel@gnu.org; Sat, 15 Jan 2022 10:44:31 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:51657) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8lEC-0000HQ-Vk for emacs-devel@gnu.org; Sat, 15 Jan 2022 10:44:30 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 621AF80582; Sat, 15 Jan 2022 10:44:26 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 563B980066; Sat, 15 Jan 2022 10:44:24 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1642261464; bh=+0C8kyVxu+LNNz8e4TfS0EMLu9bsi+mb1NQlIo5L9vE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ls3TLLOSRZHwZe7jJuUvJejbH3mQybdS1at9hTo159503nE0mQGR5pSUDajDasoUF jAAaSpUMImXsb73Gr76oNSXcaV36EIqoXE/pYCGTGwHee2UoKgzl8w+h8WTBvmnNJ7 Db5cCvbtfGc+dhPio+m6nPXVMnu4AHjkEj3i/VhpsoXOH0x+fPRwBOk03AGP47XIli Slrvs012YTQZNNdTRZjTX0gb07FhXqNAJgvYoiPexYkmkmJVlajWHZ3KYUVExzCeNb 7bCvck0BN1nJsFL7pR3KOVMDUAk7XpcIas/haRjonjwHKqxA6aKn5+oMWmd2T6Mxd0 0pCGtPW/x3CuQ== Original-Received: from pastel (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2A3511201C2; Sat, 15 Jan 2022 10:44:24 -0500 (EST) In-Reply-To: <20220115145717.E3D2BC0DA2E@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Sat, 15 Jan 2022 09:57:17 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284779 Archived-At: > + ;; XXX NOTE: For some reason Emacs sometimes converts > + ;; cape--done to (t . cape--done). `unread-command-events` is pretty tricky/nasty to get right. So I'm not sure if what you see is normal or is a bug. This said, the docstring says: Events read from this list are not normally added to =E2=80=98this-comm= and-keys=E2=80=99, as they will already have been added once as they were read for the fir= st time. An element of the form (t . EVENT) forces EVENT to be added to that lis= t. An element of the form (no-record . EVENT) means process EVENT, but do = not record it in the keyboard macros, recent-keys, and the dribble file. So it sounds like (t . cape--done) would be an error, given that I can't think of a good reason why we'd want to add the pseudo-event `cape--done` to `this-command-keys`. So, if you can find a recipe to reproduce the problem, it would be good to report it as a bug (see how it's used in async-style code with a `sit-for` loop, I expect it'll be nasty to reproduce and even worse to debug). Stefan