From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: feature/package+vc 04c4c578c7 3/4: Allow for packages to be installed directly from VCS Date: Fri, 21 Oct 2022 18:34:53 -0400 Message-ID: References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <20220214140020.04438C00891@vcs2.savannah.gnu.org> <87bkqmqpvb.fsf@posteo.net> <871qris3xb.fsf@gnus.org> <877d1aqoc1.fsf@posteo.net> <87edvhqdrb.fsf@gnus.org> <871qrh2hh6.fsf@posteo.net> <87mta5oyec.fsf@gnus.org> <87sfjx10x1.fsf@posteo.net> <875ygsp0ng.fsf@gnus.org> <87h70c9bu4.fsf@posteo.net> <874jw73cjy.fsf@posteo.net> <87edv72z11.fsf@posteo.net> <87czaq1i3k.fsf@posteo.net> <87fsfkhnhm.fsf@posteo.net> <87mt9s47f1.fsf@posteo.net> <871qr0kfeu.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39443"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 22 01:35:51 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1om1YN-000A5v-FW for ged-emacs-devel@m.gmane-mx.org; Sat, 22 Oct 2022 01:35:51 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1om0bb-0007Nl-4x; Fri, 21 Oct 2022 18:35:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1om0bW-0007NQ-L6 for emacs-devel@gnu.org; Fri, 21 Oct 2022 18:35:03 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1om0bS-0005gJ-4l for emacs-devel@gnu.org; Fri, 21 Oct 2022 18:35:01 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4FC311002F0; Fri, 21 Oct 2022 18:34:56 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id AC3E810001F; Fri, 21 Oct 2022 18:34:54 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1666391694; bh=VqJml4RmMe3ZxhNwqCd4vzHrRsifVlygqefp89uqIm0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=lNiiHoUXN/hSDUNCqFd9iQX7yjzvEQjlRbFr7Wj/XeFVrHPhMyguKmQaNgFx06JYO b9gk3LZDJxg+v0s6htGlH2JEG8zTBBJ55Hv7FBLp1qqDuzrolD/IfetsfXuYo0n5Yd oYmHHx9qhLD/D8/wSFOgYDOYCm32tfSmQ7dt1bxm6BfZPfYUnqOkeZpokq44dy4ylw BR+spTkc1ljIXujdc1AaXwX6ACh1i6KoD0qK0YFLsQtWMmpTYuEQeoPjfU3LXiIq3Z LcXn9vVPBTlu4XcVVyKv0Mvjf2UR9fz7ErCuNNKdO89HfN1H7VGZQsJnXFTvtSnJ2h j+M5ExJChGjrQ== Original-Received: from pastel (65-110-220-202.cpe.pppoe.ca [65.110.220.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7F862120201; Fri, 21 Oct 2022 18:34:54 -0400 (EDT) In-Reply-To: <871qr0kfeu.fsf@posteo.net> (Philip Kaludercic's message of "Fri, 21 Oct 2022 21:58:17 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298243 Archived-At: >> I'm thinking of things like the code that handles `:doc` or `:make`. >> These don't care about Git. > For something like :make to work, we would also require :renames, right? No, it's done before renames. > But if that is added, then the version control could break. In the part of `elpa-admin.el` designed for "install from Git" (i.e. the part that matches package+vc's goal), `:rename` is not taken into account. I don't think we can reasonably do so, as you point out, so I think `:renames` should be labeled as something we can't support (and eventually deprecated for that reason). > How does this look like: I'm a bit confused: it seems to do for `:core` what I expected to happen for packages with a nil `:url` (and it doesn't drop `:core` packages, like I'd expect). Other than that, it looks OK (in the nitpick area, I'd move the code to its own function and then call it from `elpaa-batch-make-all-packages`). I like the `.eld` extension, and I guess "elpa-packages.eld" is as good a name as any. > It currently makes the assumption that :core is the first element in the > property list for each package specification. That's right: that element should be either `:core` or `:url`. Stefan