From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Initial fontification in sh-mode with tree-sittter Date: Fri, 28 Oct 2022 12:15:01 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18045"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: =?windows-1252?Q?Jo=E3o?= Paulo Labegalini de Carvalho , emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 28 18:16:35 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ooS27-0004TB-1y for ged-emacs-devel@m.gmane-mx.org; Fri, 28 Oct 2022 18:16:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooS0o-0005C6-Jf; Fri, 28 Oct 2022 12:15:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooS0k-0005Bd-1Q for emacs-devel@gnu.org; Fri, 28 Oct 2022 12:15:10 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooS0h-0007GS-7s for emacs-devel@gnu.org; Fri, 28 Oct 2022 12:15:09 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id EE4B0100197; Fri, 28 Oct 2022 12:15:04 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4BC8A1000EF; Fri, 28 Oct 2022 12:15:03 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1666973703; bh=xmrO8VRVY/c7p2P/ch8tD11TK6l7t9VZIyuJrCoJ+pU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=An82uk5/bRVcuCdc+UX1rooi05e+U3LS9SOHuGXQwF7d+6f/ZRsAToeoUj7RhxYD3 MjNpWM1/eQLdlALuIFDyio/4bJNSeQlpvpTtRkYaLBXhx3UKfhDKqyD0hLekxUVNQ6 i+okfPCQ1nLtcqyKOWVZKgoPKtcrHSYn+WtN+Edo3EJU/8I/hpVNYCntNS/qvAgvLR eBRq6wKbwUw4MeoViofDvhq2PSB5WLKyZFkwU1SxrVw9uzR9y9OyllnPAk2zyCYhc6 YOgird9Jog2o9xgzRu36IUJEgRPTx8sAVJFa2yzyrp76XdLHdYbtKmbFz0rw6hBCri bhsVDroLvo9Gw== Original-Received: from alfajor (bras-base-mtrlpq429tw-grc-18-142-120-181-131.dsl.bell.ca [142.120.181.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 16D481200A5; Fri, 28 Oct 2022 12:15:03 -0400 (EDT) In-Reply-To: (Stefan Kangas's message of "Fri, 28 Oct 2022 08:57:07 -0700") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298682 Archived-At: Stefan Kangas [2022-10-28 08:57:07] wrote: > Jo=E3o Paulo Labegalini de Carvalho writes: >> + (setq-local treesit-font-lock-feature-list >> + '((basic) (moderate) (elaborate))) > I see that most modes on the branch seem to be using those three symbols > for now. Indeed, it's sad. It's goes against the idea being `treesit-font-lock-feature-list` which is to map features to levels. It doesn't make much sense to call a highlight feature "moderate". Highlight feature names should be things like "function names", "nested functions", "multiline docstrings", "punctuation". Stefan