From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: scratch/backend-completion 9a62da21c2 1/2: Integrate Stefan suggestions but rename it to "external-completion.el" Date: Sun, 04 Dec 2022 11:54:30 -0500 Message-ID: References: <167007345844.23701.8454474119701440468@vcs2.savannah.gnu.org> <20221203131739.2A601C004BA@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="948"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 04 17:55:22 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p1sGw-000AeX-8p for ged-emacs-devel@m.gmane-mx.org; Sun, 04 Dec 2022 17:55:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p1sGH-0006a4-1b; Sun, 04 Dec 2022 11:54:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1sGF-0006Zt-JH for emacs-devel@gnu.org; Sun, 04 Dec 2022 11:54:39 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1sGD-0001eW-NJ for emacs-devel@gnu.org; Sun, 04 Dec 2022 11:54:39 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 98C3480436; Sun, 4 Dec 2022 11:54:33 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id EB22480073; Sun, 4 Dec 2022 11:54:31 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1670172872; bh=cRC0dHKFVTn2+nPEyClufzxftG2tA9fXi0oRKs4YO8U=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=L9k6aCqNu6rn2+6oofJdkPt/UAVqfK0k2oBLpdxhBpQGvv5OUD66L+k55YVo+Qxga xrpAR0RvKW1JO+50Y/srkyLNRqVWt8YEH+BIrs1GqGfok2NfYJbXD7k03+vVff5TRv bIfjqbwLv7sdFDKNLjas7k9pJC6OXz765+7ldIPpM/cz7Ws+JoB2phEeuUOh2JrT3W xtkqjOWonf4QuL++B66Gpff6/AN3pamJO/yfV2BulCTWbPCXDDufIZV5lhs18b40F2 gSqbz4YLF7AH0DVkwgnu9DLKBBp32gEreRh6WaRr1uMeQzaYn2F7pTieYu+Z5E8IQq o2J287UGVx2kw== Original-Received: from pastel (unknown [45.72.193.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C509B120FAE; Sun, 4 Dec 2022 11:54:31 -0500 (EST) In-Reply-To: (=?windows-1252?Q?=22Jo=E3o_T=E1vora=22's?= message of "Sun, 4 Dec 2022 10:02:39 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300907 Archived-At: >> For prefix completion, it works great. >> For completion styles like `flex`, it's rarely able to complete anything. > Alright, that helps, thanks. But what use can you imagine try-completion > having with an external tool like LSP or my everything.exe client which > does regex-style? Or some other external tool you can think of... There's one I can think of: SLY, because there external tool's completion code can be tweaked to fit the needs of Emacs :-) For most others it's probably difficult, indeed, which is why I suggested to make it optional (unless you know how the tool does its matching in which case you may be able to re-use `completion-pcm--merge-try` or to implement something similar). > Else, I think we end up contacting the external tool one too many times for > the same PATTERN. That's at least with the popular completion front-ends > such as fido/vertico who probably go for the 'allc' immediately. The default UI uses either tryc (when you hit TAB) or allc (when you ask the see *Completions*) not both. Stefan