From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: pcase generates an unprintable expansion for a form in test erc--restore-initialize-priors Date: Mon, 27 May 2024 18:31:34 -0400 Message-ID: References: <87o78rrozh.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12331"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Alan Mackenzie , emacs-devel@gnu.org To: F. Jason Park Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 28 00:32:41 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sBitV-00030C-2U for ged-emacs-devel@m.gmane-mx.org; Tue, 28 May 2024 00:32:41 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sBisj-0008Hq-90; Mon, 27 May 2024 18:31:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBish-0008HQ-EU for emacs-devel@gnu.org; Mon, 27 May 2024 18:31:51 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBisf-0006r9-IP for emacs-devel@gnu.org; Mon, 27 May 2024 18:31:50 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 13701100043; Mon, 27 May 2024 18:31:47 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1716849101; bh=tATGr4Y/OthT9xVt4JJg1wfA76j5o0C438RB/CL2SuA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=erBT4mYq6w4eH0eq/6UKqxWrAdNoEx3Kb7kU7wbzGmwhyN04lr1GILYle1HWCMNy2 iV6xhntd4aoDURQ9rrNM6HUn8uyshhzTqZrbPBp5/NEVzJlWBJTEQBH+BQl/VbNniv okVEJKRVl4UVHhHpUz9FDpeBVa6iSGLnuoY0hA5sqboPGfO0gnPBKuOPPOhh4LhBb+ Hcr9zJd0bzlTu+dVAsr2sOqP9vPHXhC8nU7eontC3Vri2Sy6brFfEqel7pnGQZRaAv PO7wrQXEDMLIkgREx1CcQCvUETAnHGUazBmz3WbuxmwaUk2C7AWyui8+2HHnyo35qh hm+Dz6KBZZvkw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 73A6810002E; Mon, 27 May 2024 18:31:41 -0400 (EDT) Original-Received: from pastel (unknown [45.72.201.106]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4446812021C; Mon, 27 May 2024 18:31:41 -0400 (EDT) In-Reply-To: <87o78rrozh.fsf@neverwas.me> (F. Jason Park's message of "Mon, 27 May 2024 13:14:58 -0700") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319634 Archived-At: >> It seems terribly brittle: every minute change to the macro will require >> matching changes to the test, and I have no idea what is the intention >> of this test so if it every fails I wouldn't know whether the error is >> in the test or in the code. > A test _like_ this might make some sense in a case where [...] Indeed, never say never. But then the test should come with a comment explaining what's going on so tht when it fails we have a fighting chance of deciding who's to blame and how to fix it. Stefan