From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: pkg-autoloads.el vs. pkg-loaddefs.el Date: Mon, 17 Jun 2024 10:04:10 -0400 Message-ID: References: <87y1adrria.fsf@localhost> <87o77zbs4j.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28030"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Ihor Radchenko Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 17 16:04:55 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sJCyd-00078m-3T for ged-emacs-devel@m.gmane-mx.org; Mon, 17 Jun 2024 16:04:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJCy9-0007T6-JH; Mon, 17 Jun 2024 10:04:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJCy5-0007Si-Lv for emacs-devel@gnu.org; Mon, 17 Jun 2024 10:04:21 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJCy2-0008Dg-LT for emacs-devel@gnu.org; Mon, 17 Jun 2024 10:04:20 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 090CB44154B; Mon, 17 Jun 2024 10:04:17 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1718633051; bh=rb0ZNw9mm9Y+zzXm08u77wlTLzLdXUvVNxPwvP8KVPg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=QIUVp3+199JdYJ1Qu2LsZX/MXCXXMBetRuie61PlCxJ1pvLBkpH9biMS3K4HPNhjw PNYAKXUff+dsM0+an/IJR1yVCJGctGvRUWClMu0++a3+Jl6j14LcA8Pk6tmGUm7onZ urJrcc3DJL8HtBzG1XXT2icEHnR9E7IW9iY+eCcYMwj0Tf9DK0cTOAq4RNDfbsNvjY CWOlDa/YDZIasYwRagg95zf+4h1J1L7vzLhQU8i+Vxl6WaS1IVUskk5FA/zxwtxIZ6 5zKTAEn/WPhBcE99wrP8KgTw7JBpNJXLry08FvYQfP7AwXyoC/csQNQicz1dh/UqlD Zpejs/zMRkMaA== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2E14E44181D; Mon, 17 Jun 2024 10:04:11 -0400 (EDT) Original-Received: from pastel (unknown [24.140.236.196]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0957F1202F2; Mon, 17 Jun 2024 10:04:11 -0400 (EDT) In-Reply-To: <87o77zbs4j.fsf@localhost> (Ihor Radchenko's message of "Mon, 17 Jun 2024 13:45:00 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320214 Archived-At: > Also makes sense. However, it potentially creates a problem for > packages like Org mode that use _both_ pkg-autoloads.el and > pkg-loaddefs.el. [ Side note: all ELPA packages that use a `-loaddefs.el` also use a `-autoloads.el`. ] > If I understand your explanation correctly, `package-activate' only > loads org-autoloads.el when Org mode is installed from ELPA. I don't know what you mean to say by that. > It means that built-in org-loaddefs.el version pre-loaded with Emacs > remains active and any changes in org-loaddefs.el in ELPA Org mode > vs. built-in Org mode are not updated. `org-loaddefs.el` shouldn't be any different from any other `org*.el` file, in this respect: if it's been loaded before the package is activated, then (hopefully) `package--reload-previously-loaded` should reload the newer file. [ I've heard various reports over the years that indicate that `package--reload-previously-loaded` doesn't always do that, but I don't know if it's because it's not called at all, or because it's called but makes wrong decisions. Also of course, there can be lots of cases where reloading a file isn't sufficient. ] Stefan