From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: patch: vc.el annotation prev/next "in place" Date: Wed, 05 Apr 2006 18:04:52 -0400 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1144274718 9134 80.91.229.2 (5 Apr 2006 22:05:18 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 5 Apr 2006 22:05:18 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 06 00:05:15 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FRG7m-0003W5-BM for ged-emacs-devel@m.gmane.org; Thu, 06 Apr 2006 00:05:14 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FRG7l-0007Zg-W3 for ged-emacs-devel@m.gmane.org; Wed, 05 Apr 2006 18:05:14 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FRG7b-0007Zb-S3 for emacs-devel@gnu.org; Wed, 05 Apr 2006 18:05:03 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FRG7Z-0007ZP-DP for emacs-devel@gnu.org; Wed, 05 Apr 2006 18:05:03 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FRG7Z-0007ZM-6k for emacs-devel@gnu.org; Wed, 05 Apr 2006 18:05:01 -0400 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FRGB8-0004Lj-9I; Wed, 05 Apr 2006 18:08:42 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 533372CE9AB; Wed, 5 Apr 2006 18:04:58 -0400 (EDT) Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id B0B6C445C; Wed, 5 Apr 2006 18:04:52 -0400 (EDT) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id 7252C71501; Wed, 5 Apr 2006 18:04:52 -0400 (EDT) Original-To: Thien-Thi Nguyen In-Reply-To: (Thien-Thi Nguyen's message of "05 Apr 2006 17:15:04 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:52459 Archived-At: > ! (temp-buffer-show-function (lambda (buf) > ! (switch-to-buffer buf) > ! (vc-annotate-display-select)))) Any time you use switch-to-buffer, you have to take into account the fact that it may signal an error (when running inside a dedicated window). > ! (vc-call annotate-command file (get-buffer-create temp-buffer-name) rev) > ! (switch-to-buffer temp-buffer-name) > ! (delete-other-windows) > ! (vc-annotate-display-select) > ! (goto-char (point-min)) Same here, but additionally `delete-other-windows' is clearly wrong in general. Stefan