unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: patch: vc.el annotation prev/next "in place"
Date: Wed, 05 Apr 2006 18:04:52 -0400	[thread overview]
Message-ID: <jwvek0bsmur.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <jku097lo6f.fsf@glug.org> (Thien-Thi Nguyen's message of "05 Apr 2006 17:15:04 -0400")

> !          (temp-buffer-show-function (lambda (buf)
> !                                       (switch-to-buffer buf)
> !                                       (vc-annotate-display-select))))

Any time you use switch-to-buffer, you have to take into account the fact
that it may signal an error (when running inside a dedicated window).

> !     (vc-call annotate-command file (get-buffer-create temp-buffer-name) rev)
> !     (switch-to-buffer temp-buffer-name)
> !     (delete-other-windows)
> !     (vc-annotate-display-select)
> !     (goto-char (point-min))

Same here, but additionally `delete-other-windows' is clearly wrong
in general.


        Stefan

  reply	other threads:[~2006-04-05 22:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-05 21:15 patch: vc.el annotation prev/next "in place" Thien-Thi Nguyen
2006-04-05 22:04 ` Stefan Monnier [this message]
2006-04-05 22:37 ` Kevin Rodgers
2006-04-11 20:29   ` Stefan Monnier
2006-04-13 16:07   ` Thien-Thi Nguyen
2006-04-13 16:26     ` Romain Francoise

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvek0bsmur.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).