From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Customizing recentf Date: Wed, 30 Aug 2006 13:17:37 -0400 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1156958302 31059 80.91.229.2 (30 Aug 2006 17:18:22 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 30 Aug 2006 17:18:22 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 30 19:18:16 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GIThQ-0000dh-Uz for ged-emacs-devel@m.gmane.org; Wed, 30 Aug 2006 19:18:02 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GIThQ-0008W0-5U for ged-emacs-devel@m.gmane.org; Wed, 30 Aug 2006 13:18:00 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GIThD-0008Vn-Kp for emacs-devel@gnu.org; Wed, 30 Aug 2006 13:17:47 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GIThB-0008Td-U6 for emacs-devel@gnu.org; Wed, 30 Aug 2006 13:17:47 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GIThB-0008TY-Oj for emacs-devel@gnu.org; Wed, 30 Aug 2006 13:17:45 -0400 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GITqd-0002Rn-3d for emacs-devel@gnu.org; Wed, 30 Aug 2006 13:27:31 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 250C72CEF87; Wed, 30 Aug 2006 13:17:45 -0400 (EDT) Original-Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 27D263FC5; Wed, 30 Aug 2006 13:17:38 -0400 (EDT) Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id E8CE04C6D25; Wed, 30 Aug 2006 13:17:37 -0400 (EDT) Original-To: Michael Mauger In-Reply-To: (Michael Mauger's message of "Tue, 29 Aug 2006 23:09:45 +0000 (UTC)") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:59117 Archived-At: > The custom-autoload and custom-loads properties are used once the c-s-v > entries have been sorted, what I'm wondering is, if processing these > before the sort makes sense, so that the optional minor mode modules get > loaded before checking their properties? That would make perfect sense, yes. > Here's an attempt (basically I moved the code to autoload out of the main > loop and put it before the sort). This did fix the problem for me and > would seem to fix the problem for other, more subtle, situations. > I didn't move the code to handle explicit requires in the c-s-v entries > since I figured that should be reserved for very special situations. > This patch should allow us to remove most of the :require settings in > autoloaded minor modes. Looks good, thank you. Stefan