define-abbrev

define-abbrev

[Andreas Röhler]

`define-abbrevs' signals:
 Wrong type argument: number-or-marker-p, nil

AFAIS error is in line 583, before pos 22271

Below the output from edebug:

Andreas Röhler

GNU Emacs 23.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.10.6) of 2007-10-28 

;;;;;;;;;

Edebug: define-abbrev
...
Result: (0 nil)
Result: t
Result: (0 nil)
Result: 0 (#o0, #x0, ?\C-@)
Result: nil
Result: (0 nil)
Result: 0 (#o0, #x0, ?\C-@)
Result: t [3 times]
Result: (0 nil)
Result: 0 (#o0, #x0, ?\C-@)
Result: (0 nil)
Result: nil [2 times]
Result: (count 0) [4 times]
Result: 0 (#o0, #x0, ?\C-@)
Result: nil
Result: (count 0)
Auto-saving...
Result: nil
Result: "xor"
Result: [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 
0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 ...]
Result: xor
Result: nil
Result: (nil force)
Result: nil [3 times]
Result: xor
Result: nil [3 times]
Result: t [2 times]
Result: xor
Result: "" [2 times]
Result: xor
Result: vhdl-template-default-hook [2 times]
Result: xor
Result: (count 0) [2 times]
Result: [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 
0 0 0 0 xor 0 0 0 0 0 0 0 0 0 0 ...] [2 times]
Result: nil
Wrong type argument: number-or-marker-p, nil


;;;;;;;;;

Re: define-abbrev

[Stefan Monnier]

> `define-abbrevs' signals:
>  Wrong type argument: number-or-marker-p, nil

Please give a precise test case.

> Below the output from edebug:

Edebug is good for debugging but is mostly useless for bug-reporting.
A good backtrace is a much better start point.


        Stefan

Re: define-abbrev

[Andreas Röhler]

Am Sonntag, 28. Oktober 2007 22:38 schrieb Stefan Monnier:
> > `define-abbrevs' signals:
> >  Wrong type argument: number-or-marker-p, nil
>
> Please give a precise test case.
>
> > Below the output from edebug:
>
> Edebug is good for debugging but is mostly useless for bug-reporting.
> A good backtrace is a much better start point.
>
>

Got two different backtraces today and yesterday 

Backtrace from yesterday at the end

Emacs -q

Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil)
  define-abbrev([0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 
0 0 0 0 0 0 0 0 0 0 0 hrr 0 0 0 0 0 0 0 ...] "hrr" "hier")
  add-abbrev([0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 
0 0 0 0 0 0 0 0 0 0 hrr 0 0 0 0 0 0 0 ...] "Mode" 1)
  add-mode-abbrev(1)
  call-interactively(add-mode-abbrev)
  execute-extended-command(nil)
  call-interactively(execute-extended-command)

...

In GNU Emacs 23.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.10.6)
 of 2007-10-28 on ...
Windowing system distributor `The X.Org Foundation', version 11.0.70199902
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: de_DE.UTF-8
  locale-coding-system: utf-8
  default-enable-multibyte-characters: t

Major mode: Debugger

Minor modes in effect:
  show-paren-mode: t
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-x C-f <M-backspace> <M-backspace> <M-backspace> <M-backspace> 
t e x t e / e i n . t x t <return> <down> <down> <down> 
<down> <right> <right> <right> <right> <return> s <left> 
M-x a d d - l o c <tab> <backspace> <backspace> <backspace> 
a b <tab> <backspace> <backspace> <M-backspace> l o 
c <tab> l <tab> - a <backspace> <backspace> a d <tab> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> C-g C-h k C-^ M-x 
a d d - <tab> m o d e - a b b <tab> <return> h r <return> 
M-x e d i t - a b b <tab> <return> C-s " h r " <left> 
<left> <left> <left> C-k C-k C-c C-c C-x c M-x e l 
e <tab> <return> <down> <down> <down> <down> <return> 
M-x c u s t o m <tab> - <backspace> i <tab> <return> 
<f8> C-x k <return> M-x c u s t o m <tab> - <backspace> 
i <tab> - v <tab> <return> d e b u g - o n <tab> e 
r r <tab> <return> <down> <down> <down> <down> <down> 
<down> <right> <right> <right> <right> <right> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<right> <right> <right> <return> 1 <return> 1 <down> 
<up> <return> 2 <down> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <left> <return> 0 C-x b e i n 
. <tab> <return> M-x <up> <up> <up> <up> <up> <return> 
h r r <return> <up> C-x 1 C-SPC <down> <down> <down> 
<down> <down> <down> <down> M-w M-x r e p o r t - e 
m <tab> <return>

Recent messages:
Creating customization setup...done
Making completion list...
Creating customization items...
Creating customization items ...done
Resetting customization items...done
Creating customization setup...done
To install your edits, invoke [State] and choose the Set operation [3 times]
Entering debugger...
Mark set
Auto-saving...done

;;;;;;;;;;;;;;;;;


`define-abbrevs' signals:
 Wrong type argument: number-or-marker-p, nil


Result: vhdl-mode-abbrev-table
Result: (("xor" #1="" vhdl-template-default-hook 0 nil) ("xnor" #1# 
vhdl-template-default-hook 0 nil) ("with" #1# vhdl-template-with-hook 0 nil) 
("while" #1# vhdl-template-while-loop-hook 0 nil) ("when" #1# 
vhdl-template-when-hook 0 nil) ("wait" #1# vhdl-template-wait-hook 0 nil) 
("variable" #1# vhdl-template-variable-hook 0 nil) ("var" #1# 
vhdl-template-variable-hook 0 nil) ("use" #1# vhdl-template-use-hook 0 nil) 
("until" #1# vhdl-template-default-hook 0 nil) ("units" #1# 
vhdl-template-default-hook 0 nil) ("unaffected" #1# 
vhdl-template-default-hook 0 nil) ("type" #1# vhdl-template-type-hook 0 nil) 
("transport" #1# vhdl-template-default-hook 0 nil) ("to" #1# 
vhdl-template-default-hook 0 nil) ("then" #1# vhdl-template-default-hook 0 
nil) ("subtype" #1# vhdl-template-subtype-hook 0 nil) ("srl" #1# 
vhdl-template-default-hook 0 nil) ("sra" #1# vhdl-template-default-hook 0 
nil) ("sll" #1# vhdl-template-default-hook 0 nil) ("sla" #1# 
vhdl-template-default-hook 0 nil) ("signal" #1# vhdl-template-signal-hook 0 
nil) ("sig" #1# vhdl-template-signal-hook 0 nil) ("shared" #1# 
vhdl-template-default-hook 0 nil) ("severity" #1# vhdl-template-default-hook 
0 nil) ("select" #1# vhdl-template-selected-signal-asst-hook 0 nil) ("ror" 
#1# vhdl-template-default-hook 0 nil) ("rol" #1# vhdl-template-default-hook 0 
nil) ("return" #1# vhdl-template-return-hook 0 nil) ("report" #1# 
vhdl-template-report-hook 0 nil) ("rem" #1# vhdl-template-default-hook 0 nil) 
("reject" #1# vhdl-template-default-hook 0 nil) ("register" #1# 
vhdl-template-default-hook 0 nil) ("record" #1# vhdl-template-default-hook 0 
nil) ("range" #1# vhdl-template-default-hook 0 nil) ("pure" #1# 
vhdl-template-default-hook 0 nil) ("process" #1# vhdl-template-process-hook 0 
nil) ("procedure" #1# vhdl-template-procedure-hook 0 nil) ("postponed" #1# 
vhdl-template-default-hook 0 nil) ("port" #1# vhdl-template-port-hook 0 nil) 
("package" #1# vhdl-template-package-hook 0 nil) ("pack" #1# 
vhdl-template-package-hook 0 nil) ("out" #1# vhdl-template-default-hook 0 
nil) ("others" #1# vhdl-template-default-hook 0 nil) ("or" #1# 
vhdl-template-default-hook 0 nil) ("open" #1# vhdl-template-default-hook 0 
nil) ("on" #1# vhdl-template-default-hook 0 nil) ("of" #1# 
vhdl-template-default-hook 0 nil) ("null" #1# vhdl-template-default-hook 0 
nil) ("not" #1# vhdl-template-default-hook 0 nil) ...)
Wrong type argument: number-or-marker-p, nil

Re: define-abbrev

[Stefan Monnier]

>> > `define-abbrevs' signals:
>> >  Wrong type argument: number-or-marker-p, nil
>> 
>> Please give a precise test case.
>> 
>> > Below the output from edebug:
>> 
>> Edebug is good for debugging but is mostly useless for bug-reporting.
>> A good backtrace is a much better start point.
>> 
>> 

> Got two different backtraces today and yesterday 

I still need a testcase.


        Stefan

Re: define-abbrev

[Andreas Röhler]

Am Montag, 29. Oktober 2007 16:38 schrieb Stefan Monnier:
> >> > `define-abbrevs' signals:
> >> >  Wrong type argument: number-or-marker-p, nil
> >>
> >> Please give a precise test case.
> >>
> >> > Below the output from edebug:
> >>
> >> Edebug is good for debugging but is mostly useless for bug-reporting.
> >> A good backtrace is a much better start point.
> >
> > Got two different backtraces today and yesterday
>
> I still need a testcase.
>
>
>         Stefan

emacs -q

cursor after "Welcome" at startscreen

M-x add-global-abbrev wo RET

M-x edit-abbrevs

Kill just inserted line "wo" 0 "Welcome"

C-c C-c

then described error occurs.

apply: Wrong type argument: number-or-marker-p, nil

Andreas Röhler


;;;;;;;;;;;

In GNU Emacs 23.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.10.6)
 of 2007-10-28 on noname
Windowing system distributor `The X.Org Foundation', version 11.0.70199902
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: de_DE.UTF-8
  locale-coding-system: utf-8
  default-enable-multibyte-characters: t

Major mode: Edit-Abbrevs

Minor modes in effect:
  show-paren-mode: t
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<up> <up> <right> <right> <right> <right> <right> <right> 
<right> M-x a d d - g l o <tab> <return> w o <return> 
M-x e d i t - a b b <tab> <return> C-s " w o " <left> 
<left> <left> <left> C-k C-c C-c M-x r e p o r t - 
e m a c s - b u <tab> <return>

Recent messages:
Loading MY-PATH/emacs/20071028/emacs/leim/leim-list.el (source)...done
Loading /usr/local/share/emacs/site-lisp/egg/leim-list.el (source)...
Finished loading /usr/local/share/emacs/site-lisp/egg/leim-list.el 
   and load others...
Loading /usr/local/share/emacs/23.0.50/leim/leim-list.el (source)...done
Loading MY-PATH/emacs/20071028/emacs/leim/leim-list.el (source)...done
Loading /usr/local/share/emacs/site-lisp/egg/leim-list.el (source)...done
Loading /usr/share/emacs/site-lisp/egg/leim-list.el (source)...done
For information about GNU Emacs and the GNU system, type C-h C-a.
Mark saved where search started
apply: Wrong type argument: number-or-marker-p, nil

Re: define-abbrev

[Stefan Monnier]

> emacs -q
> cursor after "Welcome" at startscreen
> M-x add-global-abbrev wo RET
> M-x edit-abbrevs
> Kill just inserted line "wo" 0 "Welcome"
> C-c C-c
> then described error occurs.
> apply: Wrong type argument: number-or-marker-p, nil

Hmm... works fine for me.  Can you try it with "emacs -Q" (in case it
depends on some change in your site-init file(s))?


        Stefan

Re: define-abbrev

[Andreas Röhler]

Am Montag, 29. Oktober 2007 21:57 schrieb Stefan Monnier:
> > emacs -q
> > cursor after "Welcome" at startscreen
> > M-x add-global-abbrev wo RET
> > M-x edit-abbrevs
> > Kill just inserted line "wo" 0 "Welcome"
> > C-c C-c
> > then described error occurs.
> > apply: Wrong type argument: number-or-marker-p, nil
>
> Hmm... works fine for me.  Can you try it with "emacs -Q" (in case it
> depends on some change in your site-init file(s))?
>
>
>         Stefan
>
>


With emacs -Q sometimes it's gone, sometimes
not. Strange enough: with -q sometimes also. Maybe the
daylight or the moon have influence too? :)

Error occurs at nearly the last line 898

      (apply 'define-abbrev table elt))))

BTW having a closer look at the code, I see abbrevs
still downcased.

What means, I still can't have different abbrevs "Te"
"te" "tE" "TE".

So for me the whole issue isn't tackled.

Can you tell me an example where this downcasing is
useful, why it's introduced once?

Why not simply render a string as is?:

genannt London Bridge

M-x 3 add-mode-abbrev

is called London Bridge


For me both GNU and Xemacs abbrev.c codes look much
simpler than new abbrev.el. I'd prefer little changes
there than having a complete new thing.

Grüße

Andreas Röhler

Re: define-abbrev

[Stefan Monnier]

> With emacs -Q sometimes it's gone, sometimes
> not. Strange enough: with -q sometimes also. Maybe the
> daylight or the moon have influence too? :)

> Error occurs at nearly the last line 898

>       (apply 'define-abbrev table elt))))

I'm pretty sure I know where the error is signalled and how to fix this
symptom, but depending on the cause the real fix might be conmpletely
different, and the cause is elsewhere (the problem seems to be that
you're somehow using an abbrev-table that was not created by
make-abbrev-table).

> BTW having a closer look at the code, I see abbrevs
> still downcased.

The behavior of abbrevs is not supposed to have changed *at all*.
If you look at the patch I installed, it only changes
doc/lispref/abbrevs.texi, but not doc/emacs/abbrevs.texi.

If you want case-fixed abbrevs, then you need to specify it in elisp:
there is currently no command to do that.  The way to specify it is to
pass ":case-fixed t" to define-abbrev.

I'll let other people take care of such UI-level issues because I do not
use abbrevs in this way at all, so I have no idea what would be
convenient and what would be insufferable.

> Can you tell me an example where this downcasing is
> useful, why it's introduced once?

No idea.  I just preserved the old behavior.

> For me both GNU and Xemacs abbrev.c codes look much
> simpler than new abbrev.el.

Tell me which part is too complex, and I may be able to help you
understand it (and add relevant comments in the code as I do that).


        Stefan

Re: define-abbrev

[Andreas Röhler]

Am Dienstag, 30. Oktober 2007 20:11 schrieb Stefan Monnier:
> > With emacs -Q sometimes it's gone, sometimes
> > not. Strange enough: with -q sometimes also. Maybe the
> > daylight or the moon have influence too? :)
> >
> > Error occurs at nearly the last line 898
> >
> >       (apply 'define-abbrev table elt))))
>
> I'm pretty sure I know where the error is signalled and how to fix this
> symptom, but depending on the cause the real fix might be conmpletely
> different, and the cause is elsewhere (the problem seems to be that
> you're somehow using an abbrev-table that was not created by
> make-abbrev-table).

My Englisch-Mode? I'll remember your remark
should I ran into trouble at this point again, thanks.

>
> > BTW having a closer look at the code, I see abbrevs
> > still downcased.
>
> The behavior of abbrevs is not supposed to have changed *at all*.
> If you look at the patch I installed, it only changes
> doc/lispref/abbrevs.texi, but not doc/emacs/abbrevs.texi.
>
> If you want case-fixed abbrevs, then you need to specify it in elisp:
> there is currently no command to do that.  The way to specify it is to
> pass ":case-fixed t" to define-abbrev.
>
> I'll let other people take care of such UI-level issues because I do not
> use abbrevs in this way at all, so I have no idea what would be
> convenient and what would be insufferable.
>
> > Can you tell me an example where this downcasing is
> > useful, why it's introduced once?
>
> No idea.  I just preserved the old behavior.

Maybe it's worthwhile to speak about. IMO behaviour as
described by the manual is a misfeature:

,----
|    Abbrev expansion preserves case; thus, `foo' expands into `find
| outer otter'; `Foo' into `Find outer otter', and `FOO' into `FIND OUTER
| OTTER' or `Find Outer Otter' according to the variable
| `abbrev-all-caps' (a non-`nil' value chooses the first of the two
| expansions).
`----

Rather an abbrev should simply deliver that expansion
which was defined without calculating things at this
point. And abbrev should take any expansion.

> > For me both GNU and Xemacs abbrev.c codes look much
> > simpler than new abbrev.el.
>
> Tell me which part is too complex, and I may be able to help you
> understand it (and add relevant comments in the code as I do that).
>
>

Thought changing the C-code to get rid of
the downcasing would be simple and it was. 

I have an abbrev.c now, which does it so far. When
multi-word abbreviations in XEmacs are debugged, I'll
try to adapt it.

An abbrev.el completely in Emacs Lisp its
certainly a chance too.

Andreas Röhler

Re: define-abbrev

[Stefan Monnier]

>> I'm pretty sure I know where the error is signalled and how to fix this
>> symptom, but depending on the cause the real fix might be conmpletely
>> different, and the cause is elsewhere (the problem seems to be that
>> you're somehow using an abbrev-table that was not created by
>> make-abbrev-table).

> My Englisch-Mode? I'll remember your remark
> should I ran into trouble at this point again, thanks.

When you get a backtrace (in define-abbrev), please try things like:

   e (abbrev-table-p table) RET

and if it says nil, try

   e (list-abbrevs t) RET

to try and figure out which abbrev table this is.

> Maybe it's worthwhile to speak about. IMO behaviour as
> described by the manual is a misfeature:

Obviously, someone went through the trouble to code the feature, so
there's no point arguing to remove it just by saying it's
a "misfeature".  Try to come up with a good way for the user to choose
the behavior she likes instead.


        Stefan