* a bug rendering ido unusable
@ 2008-04-29 17:05 Paul Pogonyshev
2008-04-29 21:26 ` Kim F. Storm
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Paul Pogonyshev @ 2008-04-29 17:05 UTC (permalink / raw)
To: emacs-devel
Hi,
I have recompiled Emacs from CVS today and found that ido no longer
differentiates between files and directories. E.g. when I type
'~/ema RET' it opens directory '~/emacs' in dired mode, instead of
navigating into it inside the minibuffer. It must be a bug since
I don't see how that is anywhere near useful.
OTOH, there doesn't seem to be any recent modifications of ido, so
this might be a problem in some other place, e.g. in a function
that does is-this-a-directory check.
This is on GNU/Linux, could matter. 'emacs -q' shows the same
behavior after 'M-x ido-mode'.
Paul
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: a bug rendering ido unusable
2008-04-29 17:05 a bug rendering ido unusable Paul Pogonyshev
@ 2008-04-29 21:26 ` Kim F. Storm
2008-04-30 3:22 ` Stefan Monnier
2008-04-30 5:59 ` Stefan Monnier
2008-04-30 7:16 ` Stefan Monnier
2 siblings, 1 reply; 9+ messages in thread
From: Kim F. Storm @ 2008-04-29 21:26 UTC (permalink / raw)
To: Paul Pogonyshev; +Cc: Stefan Monnier, emacs-devel
Paul Pogonyshev <pogonyshev@gmx.net> writes:
> Hi,
>
> I have recompiled Emacs from CVS today and found that ido no longer
> differentiates between files and directories. E.g. when I type
> '~/ema RET' it opens directory '~/emacs' in dired mode, instead of
> navigating into it inside the minibuffer. It must be a bug since
> I don't see how that is anywhere near useful.
>
> OTOH, there doesn't seem to be any recent modifications of ido, so
> this might be a problem in some other place, e.g. in a function
> that does is-this-a-directory check.
>
> This is on GNU/Linux, could matter. 'emacs -q' shows the same
> behavior after 'M-x ido-mode'.
There has been a lot of changes to the basic completion stuff - maybe
some of those changes broke ido.
I don't have time to look into it at this time - so if someone else
could take a look I'd appreciate it.
Stefan, do you know what might have happened ??
--
Kim F. Storm <storm@cua.dk> http://www.cua.dk
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: a bug rendering ido unusable
2008-04-29 21:26 ` Kim F. Storm
@ 2008-04-30 3:22 ` Stefan Monnier
0 siblings, 0 replies; 9+ messages in thread
From: Stefan Monnier @ 2008-04-30 3:22 UTC (permalink / raw)
To: Kim F. Storm; +Cc: emacs-devel, Paul Pogonyshev
>> Hi,
>>
>> I have recompiled Emacs from CVS today and found that ido no longer
>> differentiates between files and directories. E.g. when I type
>> '~/ema RET' it opens directory '~/emacs' in dired mode, instead of
>> navigating into it inside the minibuffer. It must be a bug since
>> I don't see how that is anywhere near useful.
>>
>> OTOH, there doesn't seem to be any recent modifications of ido, so
>> this might be a problem in some other place, e.g. in a function
>> that does is-this-a-directory check.
>>
>> This is on GNU/Linux, could matter. 'emacs -q' shows the same
>> behavior after 'M-x ido-mode'.
> There has been a lot of changes to the basic completion stuff - maybe
> some of those changes broke ido.
Yes, that's the most likely explanation.
> I don't have time to look into it at this time - so if someone else
> could take a look I'd appreciate it.
> Stefan, do you know what might have happened ??
The handling of completion predicate together with
read-file-name-internal has changed and I think it's the most
likely culprit. I haven't had time to look into it yet, tho,
Stefan
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: a bug rendering ido unusable
2008-04-29 17:05 a bug rendering ido unusable Paul Pogonyshev
2008-04-29 21:26 ` Kim F. Storm
@ 2008-04-30 5:59 ` Stefan Monnier
2008-04-30 6:34 ` Drew Adams
2008-04-30 7:16 ` Stefan Monnier
2 siblings, 1 reply; 9+ messages in thread
From: Stefan Monnier @ 2008-04-30 5:59 UTC (permalink / raw)
To: Paul Pogonyshev; +Cc: emacs-devel
> I have recompiled Emacs from CVS today and found that ido no longer
> differentiates between files and directories. E.g. when I type
> '~/ema RET' it opens directory '~/emacs' in dired mode, instead of
> navigating into it inside the minibuffer. It must be a bug since
> I don't see how that is anywhere near useful.
It turns out the problem is in file-name-all-completions: for some
reason, it fails to add the expected trailing / on directories.
Stefan
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: a bug rendering ido unusable
2008-04-30 5:59 ` Stefan Monnier
@ 2008-04-30 6:34 ` Drew Adams
0 siblings, 0 replies; 9+ messages in thread
From: Drew Adams @ 2008-04-30 6:34 UTC (permalink / raw)
To: 'Stefan Monnier', 'Paul Pogonyshev'; +Cc: emacs-devel
> > I have recompiled Emacs from CVS today and found that ido no longer
> > differentiates between files and directories. E.g. when I type
> > '~/ema RET' it opens directory '~/emacs' in dired mode, instead of
> > navigating into it inside the minibuffer. It must be a bug since
> > I don't see how that is anywhere near useful.
>
> It turns out the problem is in file-name-all-completions: for some
> reason, it fails to add the expected trailing / on directories.
Thanks for that info. I got a similar bug report for Icicles.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: a bug rendering ido unusable
2008-04-29 17:05 a bug rendering ido unusable Paul Pogonyshev
2008-04-29 21:26 ` Kim F. Storm
2008-04-30 5:59 ` Stefan Monnier
@ 2008-04-30 7:16 ` Stefan Monnier
2008-04-30 20:15 ` Paul Pogonyshev
2 siblings, 1 reply; 9+ messages in thread
From: Stefan Monnier @ 2008-04-30 7:16 UTC (permalink / raw)
To: Paul Pogonyshev; +Cc: emacs-devel
> I have recompiled Emacs from CVS today and found that ido no longer
> differentiates between files and directories. E.g. when I type
It should be fixed now,
Stefan
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: a bug rendering ido unusable
2008-04-30 7:16 ` Stefan Monnier
@ 2008-04-30 20:15 ` Paul Pogonyshev
2008-05-01 23:48 ` Len Trigg
2008-05-01 23:48 ` Len Trigg
0 siblings, 2 replies; 9+ messages in thread
From: Paul Pogonyshev @ 2008-04-30 20:15 UTC (permalink / raw)
To: emacs-devel; +Cc: Stefan Monnier
Stefan Monnier wrote:
> > I have recompiled Emacs from CVS today and found that ido no longer
> > differentiates between files and directories. E.g. when I type
>
> It should be fixed now,
Yes, it is. Thank you.
Paul
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: a bug rendering ido unusable
2008-04-30 20:15 ` Paul Pogonyshev
@ 2008-05-01 23:48 ` Len Trigg
2008-05-01 23:48 ` Len Trigg
1 sibling, 0 replies; 9+ messages in thread
From: Len Trigg @ 2008-05-01 23:48 UTC (permalink / raw)
To: emacs-devel; +Cc: Stefan Monnier
Paul Pogonyshev wrote:
> Stefan Monnier wrote:
> > > I have recompiled Emacs from CVS today and found that ido no longer
> > > differentiates between files and directories. E.g. when I type
> >
> > It should be fixed now,
>
> Yes, it is. Thank you.
Hmmm, I did a clean build from CVS today, and it still happens for me
on at least one directory. From ~/reeltwo_sandboxes/vetech/ all
completions show no trailing slash on subdirectories. I have no idea
why this directory behaves differently to others.
Cheers,
Len.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: a bug rendering ido unusable
2008-04-30 20:15 ` Paul Pogonyshev
2008-05-01 23:48 ` Len Trigg
@ 2008-05-01 23:48 ` Len Trigg
1 sibling, 0 replies; 9+ messages in thread
From: Len Trigg @ 2008-05-01 23:48 UTC (permalink / raw)
To: emacs-devel; +Cc: Stefan Monnier
Paul Pogonyshev wrote:
> Stefan Monnier wrote:
> > > I have recompiled Emacs from CVS today and found that ido no longer
> > > differentiates between files and directories. E.g. when I type
> >
> > It should be fixed now,
>
> Yes, it is. Thank you.
Hmmm, I did a clean build from CVS today, and it still happens for me
on at least one directory. From ~/reeltwo_sandboxes/vetech/ all
completions show no trailing slash on subdirectories. I have no idea
why this directory behaves differently to others.
Cheers,
Len.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2008-05-01 23:48 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-29 17:05 a bug rendering ido unusable Paul Pogonyshev
2008-04-29 21:26 ` Kim F. Storm
2008-04-30 3:22 ` Stefan Monnier
2008-04-30 5:59 ` Stefan Monnier
2008-04-30 6:34 ` Drew Adams
2008-04-30 7:16 ` Stefan Monnier
2008-04-30 20:15 ` Paul Pogonyshev
2008-05-01 23:48 ` Len Trigg
2008-05-01 23:48 ` Len Trigg
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).