* vc-find-root
@ 2008-10-28 20:32 Glenn Morris
2008-10-28 22:01 ` vc-find-root Stefan Monnier
0 siblings, 1 reply; 2+ messages in thread
From: Glenn Morris @ 2008-10-28 20:32 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
It doesn't make sense to both have a function definition for
vc-find-root in vc-hooks, and also have it be an alias for
locate-dominating-file.
I imagine you wanted `make-obsolete' rather than
`define-obsolete-function-alias' (and perhaps make
vc-ignore-dir-regexp an obsolete alias for
locate-dominating-stop-dir-regexp?); either that or remove the
stand-alone definitions of vc-ignore-dir-regexp and vc-find-root
altogether.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: vc-find-root
2008-10-28 20:32 vc-find-root Glenn Morris
@ 2008-10-28 22:01 ` Stefan Monnier
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2008-10-28 22:01 UTC (permalink / raw)
To: Glenn Morris; +Cc: emacs-devel
> It doesn't make sense to both have a function definition for
> vc-find-root in vc-hooks, and also have it be an alias for
> locate-dominating-file.
> I imagine you wanted `make-obsolete' rather than
> `define-obsolete-function-alias' (and perhaps make
> vc-ignore-dir-regexp an obsolete alias for
> locate-dominating-stop-dir-regexp?); either that or remove the
> stand-alone definitions of vc-ignore-dir-regexp and vc-find-root
> altogether.
The alias is a left over, sorry, it should be removed.
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-28 22:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-28 20:32 vc-find-root Glenn Morris
2008-10-28 22:01 ` vc-find-root Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).