From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Terminology in multi-tty primitives Date: Fri, 02 Jan 2009 21:32:11 -0500 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1230949954 30079 80.91.229.12 (3 Jan 2009 02:32:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 3 Jan 2009 02:32:34 +0000 (UTC) Cc: cyd@stupidchicken.com, stephen@xemacs.org, rms@gnu.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 03 03:33:42 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LIwKb-0007RD-TW for ged-emacs-devel@m.gmane.org; Sat, 03 Jan 2009 03:33:42 +0100 Original-Received: from localhost ([127.0.0.1]:60793 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LIwJM-0002Uv-Jc for ged-emacs-devel@m.gmane.org; Fri, 02 Jan 2009 21:32:24 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LIwJI-0002Uq-GC for emacs-devel@gnu.org; Fri, 02 Jan 2009 21:32:20 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LIwJG-0002Ue-1B for emacs-devel@gnu.org; Fri, 02 Jan 2009 21:32:19 -0500 Original-Received: from [199.232.76.173] (port=46443 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LIwJF-0002Ub-RB for emacs-devel@gnu.org; Fri, 02 Jan 2009 21:32:17 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:49945) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LIwJC-0002hG-LU; Fri, 02 Jan 2009 21:32:14 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArcEAO5cXklFxLKh/2dsb2JhbACBbMhrhXKBaQ X-IronPort-AV: E=Sophos;i="4.36,320,1228107600"; d="scan'208";a="31741114" Original-Received: from 69-196-178-161.dsl.teksavvy.com (HELO ceviche.home) ([69.196.178.161]) by ironport2-out.teksavvy.com with ESMTP; 02 Jan 2009 21:32:11 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id C6CEEB41B5; Fri, 2 Jan 2009 21:32:11 -0500 (EST) In-Reply-To: (Eli Zaretskii's message of "Fri, 02 Jan 2009 15:56:37 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:107539 Archived-At: >> I think calls to make-frame-on-tty should be replaceable by just >> >> (make-frame `((tty . ,tty) (tty-type . ,type) . ,parameters)))) >> >> I.e. the explicit `tty' parameter should be interpreted by make-frame as >> overriding the window-system of the current frame. > I won't object to such a change, but I must say I don't see how that > would be more elegant than the current code in make-frame-on-tty. > Perhaps even less elegant: make-frame-on-tty is a user command, so it > can sustain more ugliness, if user-level considerations justify that. > By contrast, make-frame is a general-purpose infrastructure, and > introducing such conditions into it makes it less general. I kind of agree. - the user-level command make-frame-on-tty doesn't seem very useful and I'd be happy to remove it. - if we remove it, then we have to replace the only call to it from Elisp, which is of course in server.el. I guess server.el can't be used under MS-DOS, so the test you added wouldn't be needed there anyway, so server.el could just as well use (make-frame `((window-system) (tty . ,tty) (tty-type . ,type) . ,parameters)) so the uglyness is not really crucial in make-frame. - still, when make-frame is called with an explicit `tty' argument but without an explicit `window-system' argument, the right thing to do is to give precedence to the `tty' and choose an appropriate window-system for it. Stefan