From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Chong Yidong <cyd@gnu.org>
Cc: Dmitry Antipov <dmantipov@yandex.ru>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109327: Generalize INTERNAL_FIELD between buffers, keyboards and frames.
Date: Wed, 08 Aug 2012 08:41:54 -0400 [thread overview]
Message-ID: <jwvehnh1s3d.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87r4rigihu.fsf@gnu.org> (Chong Yidong's message of "Wed, 08 Aug 2012 11:39:09 +0800")
> Another problem, which I haven't seen mentioned in this thread, is that
> when you see C code which does FVAR (x, y) the natural assumption is
> that x and y are C variables. So these macros hurt code readability.
> The introduction of BVAR also violated this principle, and I'm not eager
> to see the problem compounded.
Yes, we should see about fixing this problem.
> I think FSET/WSET/PSET/PGET/etc should be removed from the trunk, at
> least for now. I recommend moving the generational GC work to a branch.
I'm OK with keeping macros for the assignments. But I'd like to hear
suggestions to reduce/eliminate the problem you mention (of field names
looking like variables).
Depending on the write-barrier, "FSET (foo->bar, val)" can be used, but
most write-barriers want to access other parts of "foo" rather than only
"foo->bar".
Maybe SET_FIELD (foo, bar, val) would be slightly better: "bar" still
looks like a variable, but at least the macro name hints at the fact
that there's a field somewhere in there.
> Isn't the point of Coccinelle to make it possible to transform the code
> with minimal manual intervention?
IIUC Coccinelle helps the work, but there is still a fair bit of manual
intervention needed afterwards, so it's not quite that simple.
Setfan
prev parent reply other threads:[~2012-08-08 12:41 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1SwCK8-0001PC-3m@vcs.savannah.gnu.org>
2012-08-01 10:33 ` [Emacs-diffs] /srv/bzr/emacs/trunk r109327: Generalize INTERNAL_FIELD between buffers, keyboards and frames Stefan Monnier
2012-08-01 12:04 ` Dmitry Antipov
2012-08-01 14:58 ` Paul Eggert
2012-08-01 16:52 ` Dmitry Antipov
2012-08-01 17:38 ` Tom Tromey
2012-08-01 21:04 ` Paul Eggert
2012-08-02 5:28 ` Stephen J. Turnbull
2012-08-01 15:01 ` Eli Zaretskii
2012-08-01 18:02 ` Dmitry Antipov
2012-08-02 15:28 ` Eli Zaretskii
2012-08-01 23:52 ` Stefan Monnier
2012-08-02 4:12 ` Dmitry Antipov
2012-08-02 5:56 ` Stephen J. Turnbull
2012-08-02 7:47 ` Dmitry Antipov
2012-08-02 9:30 ` Juanma Barranquero
2012-08-02 16:07 ` Eli Zaretskii
2012-08-02 15:45 ` Eli Zaretskii
2012-08-02 21:28 ` Paul Eggert
2012-08-03 6:27 ` Eli Zaretskii
2012-08-03 6:52 ` Paul Eggert
2012-08-02 23:38 ` Richard Stallman
2012-08-02 15:34 ` Eli Zaretskii
2012-08-03 7:42 ` Stefan Monnier
2012-08-03 8:31 ` Dmitry Antipov
2012-08-03 18:58 ` Paul Eggert
2012-08-03 22:52 ` Stefan Monnier
2012-08-04 16:31 ` Paul Eggert
2012-08-05 15:03 ` Dmitry Antipov
2012-08-06 10:54 ` Stefan Monnier
2012-08-06 11:44 ` Dmitry Antipov
2012-08-06 16:31 ` Stefan Monnier
2012-08-06 17:43 ` Stefan Monnier
2012-08-08 7:22 ` Chong Yidong
2012-08-05 14:59 ` Dmitry Antipov
2012-08-05 15:23 ` Paul Eggert
2012-08-05 20:29 ` Miles Bader
2012-08-03 22:50 ` Stefan Monnier
2012-08-03 23:11 ` Wojciech Meyer
2012-08-08 3:39 ` Chong Yidong
2012-08-08 7:14 ` Dmitry Antipov
2012-08-08 7:46 ` Chong Yidong
2012-08-08 10:18 ` Dmitry Antipov
2012-08-08 12:41 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvehnh1s3d.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=cyd@gnu.org \
--cc=dmantipov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).