From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: [PATCH] partial revert of overlays (+patch)
Date: Mon, 13 Aug 2012 17:01:54 -0400 [thread overview]
Message-ID: <jwvehnawlqu.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <5028F7E8.9000304@yandex.ru> (Dmitry Antipov's message of "Mon, 13 Aug 2012 16:49:44 +0400")
> OK, this is the partial revert: OV_xxx are dropped,
> buffer_set_overlays_(before|after) are used to set an appropriate
> pointers, and the rest is not touched (I suppose that unchain_both
> and buffer_has_overlays are OK).
Looks OK, thank you.
> - for (ov = buffer_get_overlays (b, OV_BEFORE); ov; ov = next)
> - {
> - drop_overlay (b, ov);
> - next = ov->next;
> - ov->next = NULL;
> - }
> -
> - for (ov = buffer_get_overlays (b, OV_AFTER); ov; ov = next)
> - {
> - drop_overlay (b, ov);
> - next = ov->next;
> - ov->next = NULL;
> - }
> -
> - buffer_set_overlays (b, NULL, OV_BEFORE);
> - buffer_set_overlays (b, NULL, OV_AFTER);
> + for (ov = b->overlays_before; ov; ov = next)
> + {
> + drop_overlay (b, ov);
> + next = ov->next;
> + ov->next = NULL;
> + }
> +
> + for (ov = b->overlays_after; ov; ov = next)
> + {
> + drop_overlay (b, ov);
> + next = ov->next;
> + ov->next = NULL;
> + }
> +
> + buffer_set_overlays_before (b, NULL);
> + buffer_set_overlays_after (b, NULL);
How did you get this hunk? Most of the lines seem 100% completely
totally unmodified and yet they appear as + and -.
Stefan
prev parent reply other threads:[~2012-08-13 21:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1T0m5d-00069X-HW@vcs.savannah.gnu.org>
[not found] ` <jwvfw7r2yl7.fsf-monnier+emacs@gnu.org>
2012-08-13 12:47 ` [PATCH] partial revert of overlays Dmitry Antipov
2012-08-13 12:49 ` [PATCH] partial revert of overlays (+patch) Dmitry Antipov
2012-08-13 21:01 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvehnawlqu.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dmantipov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).