From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109864: Fix minor problems found by static checking. Date: Mon, 03 Sep 2012 14:54:49 -0400 Message-ID: References: <83392zf7bu.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1346698500 23717 80.91.229.3 (3 Sep 2012 18:55:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 3 Sep 2012 18:55:00 +0000 (UTC) Cc: Paul Eggert , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 03 20:55:02 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T8bnW-00087A-OD for ged-emacs-devel@m.gmane.org; Mon, 03 Sep 2012 20:54:58 +0200 Original-Received: from localhost ([::1]:53857 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8bnU-0005NR-3z for ged-emacs-devel@m.gmane.org; Mon, 03 Sep 2012 14:54:56 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8bnR-0005N6-Gp for emacs-devel@gnu.org; Mon, 03 Sep 2012 14:54:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T8bnQ-0005Rb-Ov for emacs-devel@gnu.org; Mon, 03 Sep 2012 14:54:53 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:8183) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8bnP-0005RA-0J; Mon, 03 Sep 2012 14:54:51 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09FxKEe/2dsb2JhbABEsEiDSYEIghUBAQQBViMFCws0EhQYDSSIHAW6CZBEA6MzgViDBQ X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="197399517" Original-Received: from 69-196-161-30.dsl.teksavvy.com (HELO pastel.home) ([69.196.161.30]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 03 Sep 2012 14:54:50 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 6CE45592D1; Mon, 3 Sep 2012 14:54:49 -0400 (EDT) In-Reply-To: <83392zf7bu.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 03 Sep 2012 18:35:01 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152969 Archived-At: >> --- a/src/doc.c 2012-09-02 16:56:31 +0000 >> +++ b/src/doc.c 2012-09-03 09:22:43 +0000 >> @@ -848,9 +848,10 @@ >> struct buffer *oldbuf; >> ptrdiff_t start_idx; >> /* This is for computing the SHADOWS arg for describe_map_tree. */ >> - Lisp_Object active_maps = Fcurrent_active_maps (Qnil, Qnil); >> + Lisp_Object active_maps; >> Lisp_Object earlier_maps; >> >> + active_maps = Fcurrent_active_maps (Qnil, Qnil); >> changed = 1; >> strp += 2; /* skip \{ or \< */ >> start = strp; > What problems did static checking find in this (and other similar) > fragment? Yes, I curious, especially since the resulting code is less elegant. Stefan