From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: cl-defstruct-based package.el, now with ert tests and no external tar! Date: Sat, 06 Apr 2013 20:43:08 -0400 Message-ID: References: <87y5cx0wh7.fsf@yandex.ru> <87ppy7e5ke.fsf@lifelogs.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1365295403 17344 80.91.229.3 (7 Apr 2013 00:43:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 7 Apr 2013 00:43:23 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 07 02:43:26 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UOdhd-0007cK-Rv for ged-emacs-devel@m.gmane.org; Sun, 07 Apr 2013 02:43:26 +0200 Original-Received: from localhost ([::1]:53915 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOdhd-0002wq-BG for ged-emacs-devel@m.gmane.org; Sat, 06 Apr 2013 20:43:25 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:50122) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOdhZ-0002wk-J9 for emacs-devel@gnu.org; Sat, 06 Apr 2013 20:43:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UOdhX-0001sG-U7 for emacs-devel@gnu.org; Sat, 06 Apr 2013 20:43:21 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:39106) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOdhX-0001s8-Op for emacs-devel@gnu.org; Sat, 06 Apr 2013 20:43:19 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFxLSu/2dsb2JhbABEvw4Xc4IeAQEEAVYoCws0EhQYDYhCBsEtjWGDKQOSWwOSHIFegxM X-IPAS-Result: Av4EABK/CFFFxLSu/2dsb2JhbABEvw4Xc4IeAQEEAVYoCws0EhQYDYhCBsEtjWGDKQOSWwOSHIFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="6701969" Original-Received: from 69-196-180-174.dsl.teksavvy.com (HELO pastel.home) ([69.196.180.174]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 06 Apr 2013 20:43:16 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id C9DBB62EFF; Sat, 6 Apr 2013 20:43:08 -0400 (EDT) In-Reply-To: <87ppy7e5ke.fsf@lifelogs.com> (Ted Zlatanov's message of "Sat, 06 Apr 2013 17:02:09 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:158741 Archived-At: > In the end it should be a single commit to the Bazaar repo, and there's > no reason to break it up for your audience here. I've been looking at the patch, trying to understand what it does, and I think I'd first really need to see a good description of what it does, because obviously it doesn't just switch to using a defstruct. It also does things like renaming functions and various minor refactorings that don't seem directly related (they don't necessarily seem bad either, but I wasn't able to understand all of what's going on from just looking at the patch). I did notice that package-desc-from-define uses ignore-errors where the previous code did not. `ignore-errors' can be handy, but it should be used with restraint because it too easily hides problems. Since the previous code didn't use them, I don't see why we'd need them now. Stefan